Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TF-3005 [SEARCH] Easily clear "from" and "to" search result header #3158

Conversation

dab246
Copy link
Member

@dab246 dab246 commented Sep 18, 2024

Issue

#3005

Resolved

  • Web:
Screen.Recording.2024-09-18.at.12.05.19.mov
  • Mobile:
android.webm

Copy link

This PR has been deployed to https://linagora.github.io/tmail-flutter/3158.

@dab246 dab246 force-pushed the improvement/tf-3002-search-more-filters-part-2 branch from 8fa4f47 to c387464 Compare October 2, 2024 09:34
@dab246 dab246 changed the base branch from improvement/tf-3002-search-more-filters-part-2 to search-improvement-sprint-28 October 7, 2024 07:40
@dab246 dab246 force-pushed the improvement/tf-3005-search-easily-clear-from-and-to-search-result branch from b22888f to 3a849fb Compare October 7, 2024 08:58
@hoangdat
Copy link
Member

hoangdat commented Oct 8, 2024

  • IMO, we should display tick to indicated selected email address. (same as mobile)
image

@dab246
Copy link
Member Author

dab246 commented Oct 8, 2024

  • IMO, we should display tick to indicated selected email address. (same as mobile)
image

What do you mean? Describe in detail.

@dab246
Copy link
Member Author

dab246 commented Oct 8, 2024

  • IMO, we should display tick to indicated selected email address. (same as mobile)
image

What do you mean? Describe in detail.

Updated

  • Web:
Screen.Recording.2024-10-08.at.16.23.43.mov
  • Mobile:
Screen_recording_20241008_162823.webm

@hoangdat
Copy link
Member

hoangdat commented Oct 8, 2024

  • if no selected email address, can we focus on search bar
Screen.Recording.2024-10-08.at.17.35.48.mov

@dab246 dab246 force-pushed the improvement/tf-3005-search-easily-clear-from-and-to-search-result branch from 05d8fe1 to e1352c6 Compare October 8, 2024 11:37
@dab246
Copy link
Member Author

dab246 commented Oct 8, 2024

  • if no selected email address, can we focus on search bar

Screen.Recording.2024-10-08.at.17.35.48.mov

Fixed

Screen.Recording.2024-10-08.at.18.34.45.mov

@hoangdat
Copy link
Member

hoangdat commented Oct 9, 2024

  • if we select multiple recipients, we should combine it as OR operation. WDYT?
image

@dab246
Copy link
Member Author

dab246 commented Oct 9, 2024

  • if we select multiple recipients, we should combine it as OR operation. WDYT?
image

It is absurd, because when user enters a field with multiple mail addresses, it only searches for emails that include all of these mail addresses. And the AND condition is reasonable.

@hoangdat hoangdat merged commit 3c66b25 into search-improvement-sprint-28 Oct 9, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants