Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TF-3007 [SEARCH] Support drag and drop between From & To field #3154

Merged
merged 2 commits into from
Oct 8, 2024
Merged

TF-3007 [SEARCH] Support drag and drop between From & To field #3154

merged 2 commits into from
Oct 8, 2024

Conversation

dab246
Copy link
Member

@dab246 dab246 commented Sep 17, 2024

Issue

#3007

Resolved

Screen.Recording.2024-09-17.at.16.35.57.mov

@dab246 dab246 requested a review from hoangdat September 17, 2024 09:43
@github-actions GitHub Actions
Copy link

This PR has been deployed to https://linagora.github.io/tmail-flutter/3154.

@dab246 dab246 added the search label Sep 17, 2024
@dab246 dab246 changed the base branch from refactor to search-improvement-sprint-28 October 7, 2024 08:35
@dab246 dab246 force-pushed the bugfix/tf-3007-search-drag-and-drop-between-from-and-to branch from eb37ade to d466033 Compare October 7, 2024 08:47
@dab246 dab246 force-pushed the bugfix/tf-3007-search-drag-and-drop-between-from-and-to branch from d466033 to 199ada0 Compare October 7, 2024 08:50
@hoangdat
Copy link
Member

hoangdat commented Oct 8, 2024 •
edited by dab246
Loading

  • open advanced search form, drag n drop a recipient from from to to field, but not click on search button, close advanced search form -> recipient was lost in advanced search form (but still in filter)
Screen.Recording.2024-10-08.at.10.36.39.mov

@dab246
Copy link
Member Author

dab246 commented Oct 8, 2024

  • open advanced search form, drag n drop a recipient from from to to field, but not click on search button, close advanced search form -> recipient was lost in advanced search form (but still in filter)

Screen.Recording.2024-10-08.at.10.36.39.mov

Currently we do not persist data when entering any field without clicking the Search button. Data persistence is done in PR #3160 @hoangdat

@dab246 dab246 requested a review from tddang-linagora October 8, 2024 07:51
@hoangdat hoangdat merged commit b510278 into search-improvement-sprint-28 Oct 8, 2024
19 checks passed
hoangdat pushed a commit that referenced this pull request Oct 15, 2024
@dab246 @hoangdat
TF-3007 [SEARCH] Support drag and drop between From & To field (#3154)
e584e61
@hoangdat hoangdat deleted the bugfix/tf-3007-search-drag-and-drop-between-from-and-to branch November 6, 2024 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tddang-linagora tddang-linagora tddang-linagora approved these changes

@hoangdat hoangdat hoangdat approved these changes

Assignees
No one assigned
Labels
search
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dab246 @hoangdat @tddang-linagora