Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PART 2] TF-3002 Search more filters #3146

Conversation

dab246
Copy link
Member

@dab246 dab246 commented Sep 13, 2024

Issue

#3002

Resolved

  • Mobile:
demo-mobile.webm
  • Web responsive:
Screen.Recording.2024-09-13.at.16.23.52.online-video-cutter.com.mp4

Copy link

This PR has been deployed to https://linagora.github.io/tmail-flutter/3146.

@dab246 dab246 force-pushed the improvement/tf-3002-search-more-filters branch from 348210d to 4245825 Compare September 16, 2024 06:30
@dab246 dab246 force-pushed the improvement/tf-3002-search-more-filters-part-2 branch from a1f70c5 to 8fa4f47 Compare September 16, 2024 06:40
@dab246 dab246 added the search label Sep 17, 2024
@dab246 dab246 force-pushed the improvement/tf-3002-search-more-filters branch from dcbf807 to 610e09e Compare October 2, 2024 08:52
@hoangdat hoangdat changed the base branch from improvement/tf-3002-search-more-filters to search-improvement-sprint-28 October 2, 2024 09:07
@hoangdat hoangdat changed the base branch from search-improvement-sprint-28 to improvement/tf-3002-search-more-filters October 2, 2024 09:08
@hoangdat
Copy link
Member

hoangdat commented Oct 2, 2024

@dab246 dab246 changed the base branch from improvement/tf-3002-search-more-filters to search-improvement-sprint-28 October 2, 2024 09:27
@dab246 dab246 force-pushed the improvement/tf-3002-search-more-filters-part-2 branch from 8fa4f47 to c387464 Compare October 2, 2024 09:34
@dab246
Copy link
Member Author

dab246 commented Oct 2, 2024

Done. @hoangdat

@hoangdat
Copy link
Member

hoangdat commented Oct 3, 2024

  • after search with keyword and other filters, I can not clear keyword to search only with filters
Screen.Recording.2024-10-03.at.10.55.53.mov

@dab246
Copy link
Member Author

dab246 commented Oct 3, 2024

  • after search with keyword and other filters, I can not clear keyword to search only with filters

Screen.Recording.2024-10-03.at.10.55.53.mov

Clear filter only deletes text and gives suggestions. You can only search after clicking enter or pressing the search button.

@hoangdat
Copy link
Member

hoangdat commented Oct 3, 2024

  • [MOBILE] when user select contact suggestion, search filter also apply this contact in both text and from.
  • Expected: only from
Screen.Recording.2024-10-03.at.11.05.41.mov

@dab246
Copy link
Member Author

dab246 commented Oct 3, 2024

  • [MOBILE] when user select contact suggestion, search filter also apply this contact in both text and from.
  • Expected: only from

Screen.Recording.2024-10-03.at.11.05.41.mov

Fixed

Screen.Recording.2024-10-03.at.11.28.42.mov

@hoangdat
Copy link
Member

hoangdat commented Oct 3, 2024

@hoangdat
Copy link
Member

hoangdat commented Oct 3, 2024

  • write test to ensure search filter send to interactor is exactly which user changed

@dab246
Copy link
Member Author

dab246 commented Oct 3, 2024

Fixed.

Screen_recording_20241003_144651.webm

@dab246
Copy link
Member Author

dab246 commented Oct 3, 2024

  • write test to ensure search filter send to interactor is exactly which user changed

Updated

@hoangdat
Copy link
Member

hoangdat commented Oct 6, 2024

  • clear text in advanced search, but text in search bar is not deleted too (filter in request is well updated)
Screen.Recording.2024-10-06.at.22.25.29.mov

@hoangdat hoangdat merged commit 3f80d69 into search-improvement-sprint-28 Oct 7, 2024
19 checks passed
@hoangdat hoangdat deleted the improvement/tf-3002-search-more-filters-part-2 branch November 6, 2024 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants