Bug fix/cannot login when token is deleted #950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hoangdat
reviewed
Mar 28, 2024
data/lib/src/network/config/retry_authentication_interceptors.dart
Outdated
Show resolved
Hide resolved
hoangdat
reviewed
Mar 28, 2024
domain/lib/src/usecases/authentication/get_authorized_user_interactor.dart
Outdated
Show resolved
Hide resolved
hoangdat
reviewed
Mar 28, 2024
…dart Co-authored-by: Dat H. Pham <[email protected]>
hoangdat
reviewed
Apr 1, 2024
domain/lib/src/usecases/authentication/get_authorized_user_interactor.dart
Outdated
Show resolved
Hide resolved
…eractor.dart Co-authored-by: Dat H. Pham <[email protected]>
hoangdat
reviewed
Apr 4, 2024
| @@ -103,6 +104,11 @@ class AuthenticationDataSourceImpl implements AuthenticationDataSource { | |||
| return userRes.toUser(); | |||
| }).catchError((error) { | |||
| _remoteExceptionThrower.throwRemoteException(error, handler: (DioError error) { | |||
| final errorCode = error.response?.headers.value(Constant.linShareAuthErrorCode) ?? '1'; | |||
| final authErrorCode = LinShareErrorCode(int.tryParse(errorCode) ?? 1); | |||
| if(authErrorCode.value==1000){ | |||
There was a problem hiding this comment.
please dont use magic number. constant 1000 in value
hoangdat
reviewed
Apr 4, 2024
hoangdat
reviewed
Apr 4, 2024
hoangdat
approved these changes
Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
gitlab ticket
When the permanent token is deleted from the web, the app gets stuck loading
Root cause
when the permanent token is deleted the
RetryAuthenticationInterceptorsfails to get a new token and throws an unhandled exception causing the app to get stuck loadingSolution