Skip to content

Commit

Permalink
LA-1206 Removed unnecessary function in GenericUserDto
Browse files Browse the repository at this point in the history
  • Loading branch information
KhaledNjim committed Apr 1, 2024
1 parent bc78254 commit a835464
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 11 deletions.
2 changes: 1 addition & 1 deletion data/lib/src/network/linshare_http_client.dart
Original file line number Diff line number Diff line change
Expand Up @@ -691,7 +691,7 @@ class LinShareHttpClient {
.withPathParameter(uploadRequestGroupId.uuid)
.withPathParameter(Endpoint.recipents)
.generateEndpointPath(),
data: recipients.map((data) => GenericUserDto(data.mail, lastName: data.lastName, firstName: data.firstName).toAddRecipientJson()).toList().toString());
data: recipients.map((data) => GenericUserDto(data.mail, lastName: data.lastName, firstName: data.firstName).toJson()).toList().toString());
return UploadRequestGroupResponse.fromJson(resultJson);
}

Expand Down
14 changes: 4 additions & 10 deletions data/lib/src/network/model/generic_user_dto.dart
Original file line number Diff line number Diff line change
Expand Up @@ -72,21 +72,15 @@ class GenericUserDto {
{
jsonEncode('mail'): jsonEncode(_mail),
jsonEncode('lastName'): jsonEncode(lastName.fold(() => '', (lastName) => lastName)),
jsonEncode('firstName'): jsonEncode(firstName.fold(() => '', (firstName) => firstName)),
jsonEncode('uuid'): jsonEncode(userId?.uuid)
jsonEncode('firstName'): jsonEncode(firstName.fold(() => '', (firstName) => firstName))
};
}


extension GenericUserDtoExtension on GenericUserDto {
GenericUser toGenericUser() {
return GenericUser(_mail ?? '', firstName: _firstName, lastName: _lastName, userId: userId);
return GenericUser(_mail ?? '', firstName: _firstName,
lastName: _lastName,
userId: userId);
}

Map<String, dynamic> toAddRecipientJson() =>
{
jsonEncode('mail'): jsonEncode(_mail),
jsonEncode('lastName'): jsonEncode(lastName.fold(() => '', (lastName) => lastName)),
jsonEncode('firstName'): jsonEncode(firstName.fold(() => '', (firstName) => firstName)),
};
}

0 comments on commit a835464

Please sign in to comment.