Open-Up/openup2018_01-barcamp#9 #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
JackieNek
changed the title
JackieNek
force-pushed
the
openup2018_01-barcamp
branch
from
87e3f91 to
dd4bcc3
Compare
|
|
kclang
reviewed
Jul 5, 2018
| @@ -1,4 +1,4 @@ | |||
| .chat-conversation-topic-edition | |||
| span.editable(ng-if="!ctrl.conversation.topic.value" editable-text="ctrl.topic" onhide="ctrl.draft($data)" buttons="no" onbeforesave='ctrl.updateTopic($data)') | |||
| | #{__('Set a topic')} | |||
| span.editable(ng-if="ctrl.conversation.topic.value" ng-bind-html="ctrl.conversation.topic.value | linky:'_blank' | esnEmoticonify:{class: 'label-emoji'}" editable-text="ctrl.topic" onhide="ctrl.draft($data)" buttons="no" onbeforesave='ctrl.updateTopic($data)') | |||
| span.editable(ng-if="ctrl.conversation.topic.value" ng-bind-html="ctrl.conversation.topic.value | linky:'_blank' | esnEmoticonify:{class: 'label-emoji'}" editable-text="ctrl.topic" onhide="ctrl.draft($data)" buttons="no" onbeforesave='ctrl.updateTopic($data)' data-trigger="hover" data-placement="down" title="{{ctrl.conversation.topic.value}}") | |||
There was a problem hiding this comment.
- Do we need
data-trigger="hover" data-placement="down"? - Please separate attributes by
,
| @@ -24,13 +24,20 @@ | |||
| } | |||
|
|
|||
| span { | |||
| .ellipsis; | |||
There was a problem hiding this comment.
it should be in chatConversationTopicEdition.
You should always css for an element in a component in css file of that component
There was a problem hiding this comment.
but it is not woking
| @@ -24,13 +24,20 @@ | |||
| } | |||
|
|
|||
| span { | |||
| .ellipsis; | |||
|
|
|||
| display: block; | |||
There was a problem hiding this comment.
please use div instead of span with display: block
| cursor: pointer; | ||
| .label-emoji { | ||
| width: @chatLabelEmojiSize; | ||
| } | ||
| } | ||
| } | ||
|
|
||
| chat-conversation-topic-edition { |
There was a problem hiding this comment.
should be in chat-conversation-topic-edition.less
| @@ -1,4 +1,4 @@ | |||
| .chat-conversation-topic-edition | |||
| span.editable(ng-if="!ctrl.conversation.topic.value" editable-text="ctrl.topic" onhide="ctrl.draft($data)" buttons="no" onbeforesave='ctrl.updateTopic($data)') | |||
| | #{__('Set a topic')} | |||
| span.editable(ng-if="ctrl.conversation.topic.value" ng-bind-html="ctrl.conversation.topic.value | linky:'_blank' | esnEmoticonify:{class: 'label-emoji'}" editable-text="ctrl.topic" onhide="ctrl.draft($data)" buttons="no" onbeforesave='ctrl.updateTopic($data)') | |||
| span.editable(ng-if="ctrl.conversation.topic.value" ng-bind-html="ctrl.conversation.topic.value | linky:'_blank' | esnEmoticonify:{class: 'label-emoji'}" editable-text="ctrl.topic" onhide="ctrl.draft($data)" buttons="no" onbeforesave='ctrl.updateTopic($data)' title="{{ctrl.conversation.topic.value}}") | |||
| @@ -42,8 +49,12 @@ | |||
| a { | |||
| color: @secondaryTextColor; | |||
| } | |||
|
|
|||
| chat-conversation-topbar-actions-members span{ | |||
| white-space: nowrap; | |||
There was a problem hiding this comment.
it keep contact icon inline
kclang
reviewed
Jul 5, 2018
| cursor: pointer; | ||
| .label-emoji { | ||
| width: @chatLabelEmojiSize; | ||
| } | ||
| } | ||
| } | ||
|
|
||
| chat-conversation-topic-edition { | ||
| width: 90%; |
JackieNek
force-pushed
the
openup2018_01-barcamp
branch
4 times, most recently
from
0c63732 to
75dec75
Compare
kclang
reviewed
Jul 6, 2018
| div { | ||
| .ellipsis; | ||
|
|
||
| display: block; |
There was a problem hiding this comment.
no need because display of div is bock by default
JackieNek
force-pushed
the
openup2018_01-barcamp
branch
2 times, most recently
from
e406899 to
fa24438
Compare
kclang
reviewed
Jul 6, 2018
| @@ -1,4 +1,4 @@ | |||
| .chat-conversation-topic-edition | |||
| span.editable(ng-if="!ctrl.conversation.topic.value" editable-text="ctrl.topic" onhide="ctrl.draft($data)" buttons="no" onbeforesave='ctrl.updateTopic($data)') | |||
| | #{__('Set a topic')} | |||
| span.editable(ng-if="ctrl.conversation.topic.value" ng-bind-html="ctrl.conversation.topic.value | linky:'_blank' | esnEmoticonify:{class: 'label-emoji'}" editable-text="ctrl.topic" onhide="ctrl.draft($data)" buttons="no" onbeforesave='ctrl.updateTopic($data)') | |||
| div.editable(ng-if="ctrl.conversation.topic.value" ng-bind-html="ctrl.conversation.topic.value | linky:'_blank' | esnEmoticonify:{class: 'label-emoji'}" editable-text="ctrl.topic" onhide="ctrl.draft($data)" buttons="no" onbeforesave='ctrl.updateTopic($data)' title="{{ctrl.conversation.topic.value}}") | |||
JackieNek
force-pushed
the
openup2018_01-barcamp
branch
8 times, most recently
from
12e477d to
b4e5ace
Compare
kclang
approved these changes
Jul 9, 2018
tuanlc
reviewed
Jul 9, 2018
| @@ -42,8 +45,12 @@ | |||
| a { | |||
| color: @secondaryTextColor; | |||
| } | |||
|
|
|||
| chat-conversation-topbar-actions-members span{ | |||
| white-space: nowrap; | |||
| width: 100%; | ||
| padding-right: 10px; | ||
|
|
||
| div { |
JackieNek
force-pushed
the
openup2018_01-barcamp
branch
from
b4e5ace to
9f0e097
Compare
tuanlc
approved these changes
Jul 9, 2018
tuanlc
approved these changes
Jul 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add ellipsis to Chat channel's topic