Skip to content

Commit

Permalink
Drop some useless TODO
Browse files Browse the repository at this point in the history
  • Loading branch information
guimard committed Mar 23, 2024
1 parent aed9051 commit d416f57
Show file tree
Hide file tree
Showing 6 changed files with 0 additions and 7 deletions.
2 changes: 0 additions & 2 deletions packages/matrix-identity-server/src/account/register.ts
Original file line number Diff line number Diff line change
Expand Up @@ -62,8 +62,6 @@ const Register = (
})
.catch((e) => {
logger.warn(`Unable to validate token ${JSON.stringify(obj)}`, e)

/* TODO: Matrix spec doesn't describe response to use it, check later if fixed */
send(res, 401, errMsg('sessionNotValidated', e))
})
})
Expand Down
1 change: 0 additions & 1 deletion packages/matrix-identity-server/src/matrixDb/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,6 @@ class MatrixDB implements MatrixDBBackend {
this.ready = new Promise((resolve, reject) => {
this.db.ready
.then(() => {
// TODO: insert here init if needed
resolve()
})
/* istanbul ignore next */
Expand Down
1 change: 0 additions & 1 deletion packages/matrix-identity-server/src/userdb/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,6 @@ class UserDB implements UserDBBackend {
this.ready = new Promise((resolve, reject) => {
this.db.ready
.then(() => {
// TODO: insert here init if needed
resolve()
})
/* istanbul ignore next */
Expand Down
1 change: 0 additions & 1 deletion packages/matrix-identity-server/src/utils.ts
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,6 @@ export const validateParameters: validateParametersType = (
}
})
if (additionalParameters.length > 0) {
// TODO: for now, accept additional params
logger.warn('Additional parameters', additionalParameters)
}
callback(content)
Expand Down
1 change: 0 additions & 1 deletion packages/matrix-identity-server/src/utils/mailer.ts
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ class Mailer {
host: conf.smtp_server,
/* istanbul ignore next */
port: conf.smtp_port != null ? conf.smtp_port : 25,
// TODO: push this to options
tls: { rejectUnauthorized: conf.smtp_verify_certificate }
}
if (conf.smtp_tls != null) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,6 @@ const RequestToken = (idServer: MatrixIdentityServer): expressAppHandler => {

// TODO: check for send_attempt

// TODO generate sid and token and store them
const sid = randomString(64)
idServer.db
.createOneTimeToken(
Expand Down

0 comments on commit d416f57

Please sign in to comment.