Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better streaming #59

Merged
merged 9 commits into from
May 8, 2024
Merged

Better streaming #59

merged 9 commits into from
May 8, 2024

Conversation

ml31415
Copy link
Collaborator

@ml31415 ml31415 commented May 2, 2024

  • Stream reading improved with respect to Sans-IO
  • pre-commit updated
  • mypy exceptions more fine-grained
  • Drop py3.9 support

@limx0
Copy link
Owner

limx0 commented May 3, 2024

LGTM, thanks @ml31415! I think we can also bump python to be >=3.10 now if you'd like?

I'll merge + fire off a release when this is ready to go.

@ml31415 ml31415 force-pushed the better_streaming branch from 5a1bf4f to 6ef0926 Compare May 3, 2024 10:53
@ml31415 ml31415 marked this pull request as ready for review May 3, 2024 10:58
@ml31415
Copy link
Collaborator Author

ml31415 commented May 3, 2024

@limx0 Guess it's good now. Let's get a release out. Btw. would be great, if you could add me as a maintainer. Some redundancy never hurts.

@ml31415 ml31415 marked this pull request as draft May 6, 2024 09:41
Improved flaky stream test
@ml31415 ml31415 force-pushed the better_streaming branch from 0cf461f to f92beac Compare May 6, 2024 19:17
@ml31415 ml31415 force-pushed the better_streaming branch from 48b0af0 to f50931c Compare May 7, 2024 14:18
@ml31415 ml31415 marked this pull request as ready for review May 7, 2024 15:01
@ml31415
Copy link
Collaborator Author

ml31415 commented May 7, 2024

Alright, really good to go now. Still a bit undertested, but anyways, a good leap forward.

@limx0 limx0 merged commit 7d7c3e1 into limx0:main May 8, 2024
5 checks passed
@ml31415 ml31415 deleted the better_streaming branch October 11, 2024 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants