Skip to content

Commit

Permalink
Update instructions to use -netdev stream
Browse files Browse the repository at this point in the history
Since QEMU 7.2 wrappers are no longer needed[0]; update the
documentation to instruct users to prefer the new options added in
2022[1] but not documented until 2024[2].

The client can be entirely removed in a future release.

[0] https://john-millikin.com/improved-unix-socket-networking-in-qemu-7.2
[1] qemu/qemu@5166fe0
[2] qemu/qemu@178413a

Signed-off-by: Tamir Duberstein <[email protected]>
  • Loading branch information
tamird committed Nov 17, 2024
1 parent f486d47 commit 6a6b270
Showing 2 changed files with 6 additions and 7 deletions.
9 changes: 4 additions & 5 deletions README.md
Original file line number Diff line number Diff line change
@@ -208,13 +208,12 @@ sudo make PREFIX=/opt/socket_vmnet uninstall.launchd
## Usage

### QEMU
Make sure that the `socket_vmnet` daemon is running, and execute QEMU via `socket_vmnet_client` as follows:
Make sure that the `socket_vmnet` daemon is running, and execute QEMU as follows:

```console
${HOMEBREW_PREFIX}/opt/socket_vmnet/bin/socket_vmnet_client \
${HOMEBREW_PREFIX}/var/run/socket_vmnet \
qemu-system-x86_64 \
-device virtio-net-pci,netdev=net0 -netdev socket,id=net0,fd=3 \
qemu-system-x86_64 \
-device virtio-net-pci,netdev=net0 \
-netdev stream,id=net0,addr.type=unix,addr.path=${HOMEBREW_PREFIX}/var/run/socket_vmnet \
-m 4096 -accel hvf -cdrom ubuntu-22.04-desktop-amd64.iso
```

4 changes: 2 additions & 2 deletions test/test.sh
Original file line number Diff line number Diff line change
@@ -15,9 +15,9 @@ fi

rm -f serial.log
echo >&2 "===== QEMU BEGIN ====="
/opt/socket_vmnet/bin/socket_vmnet_client "$SOCKET" qemu-system-x86_64 \
qemu-system-x86_64 \
-device virtio-net-pci,netdev=net0 \
-netdev socket,id=net0,fd=3 \
-netdev stream,id=net0,addr.type=unix,addr.path="$SOCKET" \
-kernel ipxe.lkrn \
-initrd test.ipxe \
-no-reboot \

0 comments on commit 6a6b270

Please sign in to comment.