Add QEMU on Windows to CI #3475
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -151,8 +151,8 @@ jobs: | |
| run: sudo make uninstall | ||
|
|
||
| windows: | ||
| name: "Windows tests (WSL2)" | ||
| runs-on: windows-2025-8-cores | ||
| timeout-minutes: 30 | ||
| steps: | ||
| - name: Enable WSL2 | ||
|
|
@@ -205,6 +205,40 @@ jobs: | |
| $env:_LIMA_WINDOWS_EXTRA_PATH = 'C:\Program Files\Git\usr\bin' | ||
| bash.exe -c "./hack/test-templates.sh templates/experimental/wsl2.yaml" | ||
|
|
||
| windows-qemu: | ||
|
There was a problem hiding this comment. Can we now drop these lines? Lines 68 to 75 in df13f30 There was a problem hiding this comment. From my experience "max" just didn't work well with WHPX acceleration. I tested it on 3 different machines in the past. I only was able to make it work by disabling specific CPU features, which were different on every machine. It was not user friendly default. I can do some canary testing to compare how it works now with newer QEMU/Windows versions and if the failures are as common as they were before. |
||
| name: "Windows tests (QEMU)" | ||
| runs-on: windows-2025 | ||
| timeout-minutes: 30 | ||
| steps: | ||
| - name: Set gitconfig | ||
| run: | | ||
| git config --global core.autocrlf false | ||
| git config --global core.eol lf | ||
| - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2 | ||
| with: | ||
| # To avoid "can't parse builtin Lima version" errors | ||
| fetch-depth: 0 | ||
| - uses: actions/setup-go@0aaccfd150d50ccaeb58ebd88d36e91967a5f35b # v5.4.0 | ||
| with: | ||
| go-version: 1.24.x | ||
| - name: Unit tests | ||
| run: go test -v ./... | ||
| - name: Make | ||
| run: make | ||
| - name: Install QEMU | ||
| run: | | ||
| winget install --silent --accept-source-agreements --accept-package-agreements --disable-interactivity SoftwareFreedomConservancy.QEMU | ||
| - name: Integration tests (QEMU, Windows host) | ||
| run: | | ||
| $env:PATH = "$pwd\_output\bin;" + 'C:\msys64\usr\bin;' + 'C:\Program Files\QEMU;' + $env:PATH | ||
| pacman -Sy --noconfirm openbsd-netcat diffutils | ||
| $env:MSYS2_ENV_CONV_EXCL = 'HOME_HOST;HOME_GUEST;_LIMA_WINDOWS_EXTRA_PATH' | ||
| $env:HOME_HOST = $(cygpath.exe "$env:USERPROFILE") | ||
| $env:HOME_GUEST = "$env:HOME_HOST" | ||
| $env:LIMACTL_CREATE_ARGS = '--vm-type=qemu' | ||
| $env:_LIMA_WINDOWS_EXTRA_PATH = 'C:\Program Files\Git\usr\bin' | ||
| bash.exe -c "./hack/test-templates.sh templates/default.yaml" | ||
|
|
||
| qemu: | ||
| name: "Integration tests (QEMU, macOS host)" | ||
| runs-on: macos-15-large # Intel | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can try this. From my observations it was less stable in a forked repo, where I have only default runners. I will apply this change after I will check the comment with qemucpu to max one.
If this will result in unstable builds it can be reverted later.