Avoid spamming the log when /dev/rtc does not exist #2801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AkihiroSuda
reviewed
Oct 25, 2024
Are you trying to use Raspberry Pi as a remote non-virtual machine guest with your PR #2000? |
|
It is a zero, so it doesn't have so many options. For the bigger Raspberry Pi, you can add* a battery RTC as well. * The Raspberry Pi 5 does feature a RTC by default, but then again the 4-5 (and 400) are more like a small ARM PC. |
afbjorklund
commented
Oct 25, 2024
For instance the Raspberry Pi does not have any real-time clock, so rely on network time synchronization instead (systemd-timesyncd). Signed-off-by: Anders F Björklund <[email protected]>
afbjorklund
force-pushed
the
rtc-warning
branch
from
6a9c144 to
92ce4be
Compare
afbjorklund
changed the title
AkihiroSuda
reviewed
Oct 25, 2024
| @@ -324,6 +324,11 @@ const deltaLimit = 2 * time.Second | |||
|
|
|||
| func (a *agent) fixSystemTimeSkew() { | |||
| for { | |||
| ok, err := timesync.HasRTC() | |||
| if !ok { | |||
| logrus.Warnf("fixSystemTimeSkew: error: %s", err.Error()) | |||
There was a problem hiding this comment.
You can use logrus.WithError
There was a problem hiding this comment.
I can add it, just didn't know if it was required (the other code is not using it yet)
AkihiroSuda
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For instance the Raspberry Pi does not have any real-time clock, so rely on network time synchronization instead (systemd-timesyncd).
Currently you get a warning every 10 seconds in the guestagent log
But it only needs to be logged once, that there is no
/dev/rtcfile.