Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[test-port-forwarding.pl] fix: add human-readable error when nc is not installed on the host #2785

Merged
merged 1 commit into from
Oct 23, 2024
Merged

[test-port-forwarding.pl] fix: add human-readable error when nc is not installed on the host #2785

merged 1 commit into from
Oct 23, 2024

Conversation

Mr-Sunglasses
Copy link
Contributor

fix: #2707

jandubois
jandubois approved these changes Oct 22, 2024
View reviewed changes
Copy link
Member

@jandubois jandubois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

@Mr-Sunglasses
Copy link
Contributor Author

@jandubois

I cause some mess in the Previous PR 😅 , I opened this new one with all the things you asked, LMK if any more work needed.

@Mr-Sunglasses Mr-Sunglasses changed the title [test-port-forwarding.pl] fix: add human-readable error when nc is not installed on the host [test-port-forwarding.pl] fix: add human-readable error when nc is not installed on the host Oct 22, 2024
AkihiroSuda
AkihiroSuda approved these changes Oct 23, 2024
View reviewed changes
Copy link
Member

@AkihiroSuda AkihiroSuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@AkihiroSuda AkihiroSuda added this to the v1.0 milestone Oct 23, 2024
@AkihiroSuda AkihiroSuda added the area/test Tests and CI label Oct 23, 2024
@AkihiroSuda AkihiroSuda merged commit cabe59d into lima-vm:master Oct 23, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jandubois jandubois jandubois approved these changes

@AkihiroSuda AkihiroSuda AkihiroSuda approved these changes

Assignees
No one assigned
Labels
area/test Tests and CI
Projects
None yet
Milestone
v1.0
Development

Successfully merging this pull request may close these issues.

hack/test-port-forwarding.pl should print a human-readable error when nc is not installed on the host
3 participants
@Mr-Sunglasses @jandubois @AkihiroSuda