Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate the jsonschema against default.yaml #2769

Merged
merged 1 commit into from
Oct 20, 2024

Conversation

afbjorklund
Copy link
Member

We don't want to use the external location of the schema*, and prefer to not use the external python tool.

* that doesn't even exist yet https://www.schemastore.org/json/

https://pypi.org/project/check-jsonschema/ check-jsonschema

So make it possible for the generator to validate that the generated schema matches the default.yaml.

Closes #2768

Copy link
Member

@AkihiroSuda AkihiroSuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@AkihiroSuda AkihiroSuda added this to the v1.0 milestone Oct 20, 2024
@AkihiroSuda AkihiroSuda merged commit 4a46c2b into lima-vm:master Oct 20, 2024
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

jsonschema should have tests
2 participants