Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[test-port-forwarding.pl] fix: add human-readable error when nc is not installed on the host #2764

Closed
wants to merge 0 commits into from
Closed

[test-port-forwarding.pl] fix: add human-readable error when nc is not installed on the host #2764

wants to merge 0 commits into from

Conversation

Mr-Sunglasses
Copy link
Contributor

fix: #2707

jandubois
jandubois requested changes Oct 19, 2024
View reviewed changes
Copy link
Member

@jandubois jandubois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really care either way about the here-document, but the repeated test for -f $instance should be eliminated.

hack/test-port-forwarding.pl Outdated Show resolved Hide resolved
hack/test-port-forwarding.pl Outdated Show resolved Hide resolved
@AkihiroSuda AkihiroSuda changed the title fix: add human-readable error when nc is not installed on the host [test-port-forwarding.pl] fix: add human-readable error when nc is not installed on the host Oct 19, 2024
@jandubois
Copy link
Member

Please squash commits

@AkihiroSuda AkihiroSuda added the area/test Tests and CI label Oct 22, 2024
@Mr-Sunglasses Mr-Sunglasses force-pushed the fix/#2707 branch 2 times, most recently from e5db111 to 3465211 Compare October 22, 2024 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AkihiroSuda AkihiroSuda AkihiroSuda left review comments

@jandubois jandubois jandubois requested changes

Assignees
No one assigned
Labels
area/test Tests and CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

hack/test-port-forwarding.pl should print a human-readable error when nc is not installed on the host
3 participants
@Mr-Sunglasses @jandubois @AkihiroSuda