Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for GRPC frame too large and context closed warning #2219

Merged
merged 1 commit into from
Feb 23, 2024

Conversation

balajiv113
Copy link
Member

Fixes #2216 and tries to fix #2218

@@ -20,7 +18,7 @@ func NewGuestAgentClient(dialFn func(ctx context.Context) (net.Conn, error)) (*G
grpc.WithContextDialer(func(ctx context.Context, target string) (net.Conn, error) {
return dialFn(ctx)
}),
grpc.WithTransportCredentials(insecure.NewCredentials()),
grpc.WithTransportCredentials(NewCredentials()),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you explain the difference?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its more of a try out from this comment
open-telemetry/opentelemetry-helm-charts#646 (comment)

I suspect, GRPC do something based on handshake response SecurityLevel. With insecure it will be NoSecurity. In this case it will be PrivacyAndIntegrity

@AkihiroSuda AkihiroSuda added this to the v0.21.0 milestone Feb 19, 2024
@AkihiroSuda
Copy link
Member

Lint is failing

Signed-off-by: Balaji Vijayakumar <[email protected]>
@@ -79,7 +79,6 @@ func (v *QEMUPacketConn) Read(b []byte) (n int, err error) {
size := binary.BigEndian.Uint32(header)
reader := io.LimitReader(v.unixConn, int64(size))
_, err = reader.Read(b)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems added by mistake

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

golangci-lint removed this

Copy link
Member

@AkihiroSuda AkihiroSuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@AkihiroSuda AkihiroSuda merged commit 0b0f0f1 into lima-vm:master Feb 23, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Getting some warnings when shutting down an instance using grpc
2 participants