-
Notifications
You must be signed in to change notification settings - Fork 621
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for GRPC frame too large and context closed warning #2219
Conversation
bfae53a
to
63c0d6f
Compare
@@ -20,7 +18,7 @@ func NewGuestAgentClient(dialFn func(ctx context.Context) (net.Conn, error)) (*G | |||
grpc.WithContextDialer(func(ctx context.Context, target string) (net.Conn, error) { | |||
return dialFn(ctx) | |||
}), | |||
grpc.WithTransportCredentials(insecure.NewCredentials()), | |||
grpc.WithTransportCredentials(NewCredentials()), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you explain the difference?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Its more of a try out from this comment
open-telemetry/opentelemetry-helm-charts#646 (comment)
I suspect, GRPC do something based on handshake response SecurityLevel
. With insecure it will be NoSecurity. In this case it will be PrivacyAndIntegrity
63c0d6f
to
b97c047
Compare
Lint is failing |
Signed-off-by: Balaji Vijayakumar <[email protected]>
b97c047
to
aa13dc0
Compare
@@ -79,7 +79,6 @@ func (v *QEMUPacketConn) Read(b []byte) (n int, err error) { | |||
size := binary.BigEndian.Uint32(header) | |||
reader := io.LimitReader(v.unixConn, int64(size)) | |||
_, err = reader.Read(b) | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems added by mistake
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
golangci-lint removed this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
Fixes #2216 and tries to fix #2218