Skip to content

Use template variables instead of LIMA_CIDATA_* bash variables #2123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 19, 2024

Conversation

jandubois
Copy link
Member

Should only be merged once #2121 has been included in a release.

@jandubois
Copy link
Member Author

Updated to include examples/k8s.yaml changes from #2102.

Also added a warning when LIMA_CIDATA appears in a provisioning script, as agreed to in #2055 (comment).

I first included the script in the warning text as well, but then decided that would be too annoying for users still running older instances:

$ l ls
WARN[0000] provisioning scripts should not reference the LIMA_CIDATA variables: "#!/bin/bash\nset -eux -o pipefail\nexport KUBECONFIG=/etc/kubernetes/admin.conf\nmkdir -p ${LIMA_CIDATA_HOME}/.kube\ncp -f $KUBECONFIG ${LIMA_CIDATA_HOME}/.kube/config\nchown -R ${LIMA_CIDATA_USER} ${LIMA_CIDATA_HOME}/.kube\n"
NAME    STATUS     SSH                VMTYPE    ARCH      CPUS    MEMORY    DISK      DIR
k8s     Running    127.0.0.1:52532    qemu      x86_64    4       4GiB      100GiB    ~/.lima/k8s

@AkihiroSuda AkihiroSuda added this to the v0.20.1 milestone Jan 10, 2024
Copy link
Member

@AkihiroSuda AkihiroSuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@jandubois jandubois marked this pull request as ready for review January 19, 2024 18:46
@jandubois jandubois merged commit 4e1cfac into lima-vm:master Jan 19, 2024
@jandubois jandubois deleted the example-templates branch January 19, 2024 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants