Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a mount script instead of editing /etc/fstab #124

Merged
merged 1 commit into from
Mar 9, 2024

Conversation

jandubois
Copy link
Member

This enables support for mount points that include spaces. /etc/fstab normally supports encoding special characters in filenames using octal constants (like "\040` for a space), but that doesn't work on Alpine.

Signed-off-by: Jan Dubois [email protected]
(cherry picked from commit eb3d0b7)

This is a cherry-pick of rancher-sandbox#15 that should have been made to the upstream repo first.

Discovered in lima-vm/lima#2235 (comment).

Relevant to lima-vm/lima#2234

This enables support for mount points that include spaces. `/etc/fstab`
normally supports encoding special characters in filenames using octal
constants (like "\040` for a space), but that doesn't work on Alpine.

Signed-off-by: Jan Dubois <[email protected]>
(cherry picked from commit eb3d0b7)
@AkihiroSuda
Copy link
Member

What should we do with /etc/fstab in an existing data disk?

@jandubois
Copy link
Member Author

What should we do with /etc/fstab in an existing data disk?

Just leave it as is?

It either works for the user because they don't have mount points with spaces in them (most likely), or it never did, in which case they would have to create a new instance to get this new functionality.

Copy link
Member

@AkihiroSuda AkihiroSuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@AkihiroSuda AkihiroSuda merged commit a4b10ce into lima-vm:main Mar 9, 2024
2 checks passed
@AkihiroSuda
Copy link
Member

Do you plan to make a new release with this?

@AkihiroSuda
Copy link
Member

Shall I make a new release by myself?

@jandubois jandubois deleted the mount-script branch March 9, 2024 02:56
@jandubois
Copy link
Member Author

Shall I make a new release by myself?

I can make a release, but I thought you wanted me to update the awk script so it doesn't require the empty line?

@AkihiroSuda
Copy link
Member

Shall I make a new release by myself?

I can make a release, but I thought you wanted me to update the awk script so it doesn't require the empty line?

Thanks, yes, updating awk is nice, but not a hard blocker.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants