Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.x update with latest changes #137

Merged
merged 23 commits into from
Dec 15, 2023

Conversation

hadomskyi
Copy link
Collaborator

ENG-12758

@codecov-commenter
Copy link

codecov-commenter commented Dec 13, 2023

Codecov Report

Attention: 363 lines in your changes are missing coverage. Please review.

Comparison is base (a613e5a) 70.70% compared to head (07d9911) 67.35%.

Files Patch % Lines
src/modules/SendTranslationToConnector.php 9.45% 67 Missing ⚠️
src/modules/FetchJobStatusFromConnector.php 39.79% 59 Missing ⚠️
src/modules/QueueManager.php 0.00% 59 Missing ⚠️
...s/repositories/external/ConnectorJobRepository.php 15.90% 37 Missing ⚠️
...tories/external/ConnectorTranslationRepository.php 22.58% 24 Missing ⚠️
...ces/appliers/field/LenzLinkFieldContentApplier.php 0.00% 15 Missing ⚠️
src/services/handlers/UpdateJobStatusHandler.php 0.00% 14 Missing ⚠️
src/services/handlers/StartQueueManagerHandler.php 67.50% 13 Missing ⚠️
src/modules/ManualJobSync.php 82.85% 12 Missing ⚠️
...handlers/SendTranslationToLiltConnectorHandler.php 67.56% 12 Missing ⚠️
... and 12 more

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@                  Coverage Diff                  @@
##             3.x-development     #137      +/-   ##
=====================================================
- Coverage              70.70%   67.35%   -3.36%     
- Complexity               827      924      +97     
=====================================================
  Files                    111      116       +5     
  Lines                   4127     4729     +602     
=====================================================
+ Hits                    2918     3185     +267     
- Misses                  1209     1544     +335     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hadomskyi hadomskyi force-pushed the 3.x-update-with-latest-changes branch from 7c53dc5 to 080d158 Compare December 13, 2023 20:02
@hadomskyi
Copy link
Collaborator Author

CI failing due to infra issue

@hadomskyi hadomskyi merged commit 621d2a1 into 3.x-development Dec 15, 2023
120 of 121 checks passed
@hadomskyi hadomskyi deleted the 3.x-update-with-latest-changes branch December 15, 2023 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants