Add tool for changing LAWs for dashboards and workbooks #12

lilatomic · 2024-07-03T03:33:30Z

No description provided.

(includes first-level too)

- use resolver from JSONSchemaSubparser - use refcache shared for all items - add separate function for parsing response objects - cull extraneous Properties classes - use references to top-level classes instead of consuming as subclasses

now unused

also fixes: - mark defs referenceable early, so they don't have a layer of recursive before they use IR_T reference - handle case where additionalProperties is True and type of property is specified - responses can reference arrays

codecov · 2024-07-05T07:56:28Z

Codecov Report

Attention: Patch coverage is 93.48786% with 59 lines in your changes missing coverage. Please review.

Project coverage is 95.02%. Comparing base (3f7f0f8) to head (d76c43a).

Files	Patch %	Lines
llamazure/azrest/openapi.py	95.40%	22 Missing ⚠️
llamazure/tools/migrate/dashboard.py	80.82%	14 Missing ⚠️
llamazure/tools/migrate/workbook.py	80.55%	14 Missing ⚠️
llamazure/tools/migrate/integration_test.py	92.95%	5 Missing ⚠️
llamazure/rbac/integration_test.py	50.00%	4 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##             main      #12       +/-   ##
===========================================
+ Coverage   52.32%   95.02%   +42.69%     
===========================================
  Files          15       40       +25     
  Lines         969     3213     +2244     
===========================================
+ Hits          507     3053     +2546     
+ Misses        462      160      -302

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

since we'll throw on the other ones

these classes have different names in the index but the same class ultimately, so we would generate the same class twice.

lilatomic added 30 commits June 26, 2024 00:05

fix: use newer name

e8c83ce

add opt for jsonschema blocks in schema

d1d819a

make subclasses a list, so we can handle nested json subclasses

6555441

add IRDef props as subclasses

57d1b17

fix name of subclass

da30d3b

add tool to migrate azure dashboards

bc83cae

make work

b4fc4ce

fix: readonly should have been required

f4a9994

wip

c2abd8f

wip: combine jsonschema and oadef since they're actually the same

ca08fc3

wip: fixup subclass names and properties appearing twice

d7a00f1

wip: slight fixup of collecting Properties classes

36289ee

wip: fix loading remote refs and fix recursive refs

de12e8b

wip: fix typename capitalisation

0ddc2b1

wip: use new parser for all defs

c6c6ec7

(includes first-level too)

wip: more use of type name

cf0fc56

wip: fix parser ordering to parse Refs

8477cc1

wip: implement allOf for pulling in props

4d02f78

wip: fix dispatching

16a3689

wip: always promote typename since the "name" is often a property name

1c52939

wip: handle optionalness of lists

f3bdbdb

wip: handle query params

07fb595

fix: use alias when serialising

9f61640

wip: array-based query params

2cb4f5e

add migrator for workbook LAW

546aca4

fix some unsafe param names (eg $filter)

c918cea

better error message and remove unused param

d03dbfb

remove nested classes from generated classes

c109cf3

remove IRTransformer.transform_oa_field

5e76d29

- use resolver from JSONSchemaSubparser - use refcache shared for all items - add separate function for parsing response objects - cull extraneous Properties classes - use references to top-level classes instead of consuming as subclasses

remove IRTransformer.resolve_oaref

5f167e5

now unused

lilatomic added 8 commits July 3, 2024 16:02

remove transform_def

7b16bfc

fix and delete tests

83c1fdc

mv param parsing

8fbc9a6

mv response parsing

61bb9f2

mv op parsing

fe26de0

fix misparsing enums as def

b23238b

add tests

998942f

also fixes: - mark defs referenceable early, so they don't have a layer of recursive before they use IR_T reference - handle case where additionalProperties is True and type of property is specified - responses can reference arrays

fix codegen for llamazure.rbac

c17a896

lilatomic force-pushed the example/modify-dashboard-source branch from 78ae0ab to c17a896 Compare July 5, 2024 07:53

lilatomic added 8 commits July 5, 2024 04:05

fmt lint

228d658

fix typechecks

082a166

fix: only consider non-error returns when calculating response types

1987a79

since we'll throw on the other ones

fix: do not embed imported classes as subclasses

8f21a53

fix: deduplicate for classes that are full inherit

b1f7f70

these classes have different names in the index but the same class ultimately, so we would generate the same class twice.

typechecks

2c8402e

remove python 3.8

59780db

add more test

5db5f1c

lilatomic force-pushed the example/modify-dashboard-source branch 2 times, most recently from 947da85 to 7269ed6 Compare July 6, 2024 05:22

add more test

63b683b

lilatomic force-pushed the example/modify-dashboard-source branch from 7269ed6 to 63b683b Compare July 6, 2024 05:29

lilatomic added 6 commits July 14, 2024 22:39

mv

ffd66e2

add restore functionality

d6e0ce4

add entry command

5ff9ba0

prep for release

b136227

commit utility for querying azure openapi specs for arbitrary predicates

6d55da9

codecov ignore some lines that are just error handling

d76c43a

lilatomic merged commit acf6533 into main Jul 15, 2024
5 checks passed

lilatomic deleted the example/modify-dashboard-source branch July 15, 2024 04:25

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add tool for changing LAWs for dashboards and workbooks #12

Add tool for changing LAWs for dashboards and workbooks #12

lilatomic commented Jul 3, 2024

codecov bot commented Jul 5, 2024 •

edited

Loading

Add tool for changing LAWs for dashboards and workbooks #12

Add tool for changing LAWs for dashboards and workbooks #12

Conversation

lilatomic commented Jul 3, 2024

codecov bot commented Jul 5, 2024 • edited Loading

Codecov Report

codecov bot commented Jul 5, 2024 •

edited

Loading