-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
4 주차 PR #6
Open
nette74
wants to merge
17
commits into
master
Choose a base branch
from
WEEK_4.00
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Id와 Date 정보를 담는다
ProductData 와 DateTimeParser 를 이용해 코드 간소화
상세보기 페이지를 위한 Dto
restcontroller 를 소문자로
product 와 같은 hashtag를 가진 글들을 가져와야 하는 것인가?
sh970901
reviewed
Nov 10, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
엔티티 객체를 바로 활용하는 것 보다 DTO를 만들어 사용하는 방법 잘 봤습니다.
이번주차도 고생많으셨습니다!!
"S-1", | ||
"회원 조회 성공", | ||
Ut.mapOf( | ||
"member", memberDto |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dto를 활용해서 요구사항에 맞추는게 더 좋겠네요!!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[접근 방법]
API를 REST 방식으로 바꾸는 과정을 수행하였습니다. 팀프로젝트에서 REST 통신만을 사용하였기 때문에, 한편으론 익숙한 부분이었으나, 로직 구현 부분에서 ERD 에 관한 이해가 부족했는지 구현을 못 한 부분이 있습니다.
또한 진행했던 팀프로젝트와 과제의 컨트롤러 return 구조가 달라서 헷갈리는 부분이 있습니다.
doc 과 jwt 는 시간이 부족하여 구현하지 못하였습니다.
[진행 현황]
[특이사항]
구현 과정에서 아쉬웠던 점 / 궁금했던 점을 정리합니다.
[Refactoring]