[TAS-2267] 🚸 Allow clicking 1/3 of the epub view to navigate #1824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nwingt
added a commit
that referenced
this pull request
Sep 20, 2024
nwingt
force-pushed
the
feature/reader-epub-navigate
branch
3 times, most recently
from
3fda96b
to
a3bf07e
Compare
nwingt
added a commit
that referenced
this pull request
Sep 20, 2024
| @@ -290,6 +292,11 @@ export default { | |||
| this.initRendition(); | |||
| document.addEventListener('keydown', this.keyListener, false); | |||
| }, | |||
| beforeDestroy() { | |||
| if (this.cleanUpClickListener) { | |||
| this.cleanUpClickListener(); | |||
There was a problem hiding this comment.
Not sure if we need to set this.cleanUpClickListener to undefined here
nwingt
force-pushed
the
feature/reader-epub-navigate
branch
from
a3bf07e
to
c83d3f1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #1822