[TAS-324] ✨ Add suggested follow list #1328
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
williamchong
requested changes
Sep 15, 2023
williamchong
reviewed
Oct 3, 2023
| currentFollowees[currentIndex] | ||
| ); | ||
|
|
||
| const followSuggestions = [...followees, ...pastFollowees].filter( |
There was a problem hiding this comment.
Should not suggest pastFollowees to users
Comment on lines
+44
to
+55
| while (suggestedSet.size < 3 && currentIndex < currentFollowees.length) { | ||
| // eslint-disable-next-line no-await-in-loop | ||
| const { followees = [], pastFollowees = [] } = await getUserFollowees( | ||
| currentFollowees[currentIndex] | ||
| ); | ||
|
|
||
| const followSuggestions = [...followees, ...pastFollowees].filter( | ||
| f => !currentFolloweesSet.has(f) | ||
| ); | ||
|
|
||
| followSuggestions.forEach(suggestion => suggestedSet.add(suggestion)); | ||
| currentIndex += 1; |
There was a problem hiding this comment.
We would want avoid just leaking the whole follower list of currentIndex to user. Thus we should limit and perform some randomization of the output
- Size of
currentFolloweesmust be larger than a number, say 3, otherwise following 1 user would always yield result from that particular list currentFolloweesshould contain some followees that are not already incurrentFolloweesSetin order to be counted towards to the size limit above- We should randomly draw from
currentFolloweesinstead of usingcurrentIndex
If the above conditions are not met, we should just return default suggestions/nothing.
Also note these rules are still not perfect, a better idea would be to use public information for suggestions, instead of non-public information like follower list i.e. use creators of NFT owned by a user
Comment on lines
+688
to
+691
| // Cache check and return cached result if it's valid | ||
| if ( | ||
| state.suggestedFollowList.length && | ||
| !currentFollowees.some(user => state.suggestedFollowList.includes(user)) |
There was a problem hiding this comment.
Should we remove entry from suggestedFollowList if user click follow in suggested list?
williamchong
added a commit
that referenced
this pull request
Oct 6, 2023
williamchong
added a commit
that referenced
this pull request
Oct 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2023-09-15.12.04.24.mov