-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
memoized backtrace_cleaner instance (Fixes #12) #14
Conversation
Work as advertised, thanks! |
any chance this can get merged? i have a few projects that i have to change Gemfiles for now :/ |
memoized backtrace_cleaner instance (Fixes #12)
Thanks! o/ |
Let's hold off on that for the moment. I want to review the other PRs and merge them if appropriate before a release goes out. I'd also like to get a feel for styles, etc. before taking that step. In the meantime, please feel free to tell me if you think a release is worth doing and I'll make a better effort to get it done. |
Okay. Makes sense. I was thinking that this pull request might make sense to publish since this gem is no longer fully functional on Rails 4.2+ otherwise |
Just to keep you both in the loop: I made a 3.0.9 gem and have been trying the past two nights to push it to Rubygems, but keep getting a "too many connection resets" error. I'll keep trying and/or open a support issue. Regarding the other two open PRs: neither seemed important enough to block a new release, and introduce new adapters. One needs updates to merge cleanly, and both probably need a more serious look anyway. I also realized that this gem has no automated tests, which is kind of a drag. I opened a issue #15 to address this. Given how it hooks into ActiveRecord, I don't have any ideas right off on how to approach this. If you have any thoughts, let's start a discussion in that issue. |
No description provided.