Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

memoized backtrace_cleaner instance (Fixes #12) #14

Merged
merged 1 commit into from
Sep 16, 2015

Conversation

mtyeh411
Copy link
Collaborator

No description provided.

@tjoyal
Copy link
Collaborator

tjoyal commented Sep 15, 2015

Work as advertised, thanks!

@mtyeh411
Copy link
Collaborator Author

any chance this can get merged? i have a few projects that i have to change Gemfiles for now :/

sjmadsen added a commit that referenced this pull request Sep 16, 2015
memoized backtrace_cleaner instance (Fixes #12)
@sjmadsen sjmadsen merged commit e46f07d into lightyear:master Sep 16, 2015
@sjmadsen
Copy link
Member

Thanks for the PR, @mtyeh411. I've also invited both you and @tjoyal as contributors to the repo so that you can push directly to it, since I've been such a bum about my maintainer duties.

@tjoyal
Copy link
Collaborator

tjoyal commented Sep 16, 2015

Thanks! o/

@mtyeh411
Copy link
Collaborator Author

@sjmadsen would you be willing to grant me gem ownership rights as well so the gem can be published? my rubygems handle is mtyeh411 (same as github handle)

cc @tjoyal

@sjmadsen
Copy link
Member

Let's hold off on that for the moment. I want to review the other PRs and merge them if appropriate before a release goes out. I'd also like to get a feel for styles, etc. before taking that step. In the meantime, please feel free to tell me if you think a release is worth doing and I'll make a better effort to get it done.

@mtyeh411
Copy link
Collaborator Author

Okay. Makes sense. I was thinking that this pull request might make sense to publish since this gem is no longer fully functional on Rails 4.2+ otherwise

@mtyeh411 mtyeh411 deleted the fix_backtrace_rails_4_2 branch September 22, 2015 21:20
@sjmadsen
Copy link
Member

Just to keep you both in the loop: I made a 3.0.9 gem and have been trying the past two nights to push it to Rubygems, but keep getting a "too many connection resets" error. I'll keep trying and/or open a support issue.

Regarding the other two open PRs: neither seemed important enough to block a new release, and introduce new adapters. One needs updates to merge cleanly, and both probably need a more serious look anyway. I also realized that this gem has no automated tests, which is kind of a drag. I opened a issue #15 to address this. Given how it hooks into ActiveRecord, I don't have any ideas right off on how to approach this. If you have any thoughts, let's start a discussion in that issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants