Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade zig 0.12.1 #216

Merged
merged 11 commits into from
Jun 18, 2024
Merged

Upgrade zig 0.12.1 #216

merged 11 commits into from
Jun 18, 2024

Conversation

krichprollsch
Copy link
Member

@krichprollsch krichprollsch commented Mar 28, 2024

@krichprollsch krichprollsch self-assigned this Mar 28, 2024
@krichprollsch krichprollsch force-pushed the upgrade-zig branch 2 times, most recently from 9c89fb5 to e55a5c6 Compare March 28, 2024 14:09
@krichprollsch
Copy link
Member Author

I have build and test issues.
relates to ziglang/zig#19414 and https://ziggit.dev/t/comptime-mutable-memory-changes/3702

$ make build
Building (debug)...
bench
└─ run jsruntime-bench
   └─ zig build-exe jsruntime-bench Debug native 1 errors
src/main_bench.zig:14:33: error: global variable contains reference to comptime var
pub const Types = public.reflect(proto.Types);
                  ~~~~~~~~~~~~~~^~~~~~~~~~~~~
referenced by:
    Types: src/generate.zig:35:49
    loadEnv__anon_6552: src/engine.zig:37:23
    remaining reference traces hidden; use '-freference-trace' to see all reference traces
error: the following command failed with 1 compilation errors:
/usr/local/zig/zig build-exe /home/pierre/wrk/jsruntime-lib/vendor/v8/x86_64-linux/debug/libc_v8.a -fsingle-threaded -ODebug --dep jsruntime_build_options --dep tigerbeetle-io --dep v8 -Mroot=/home/pierre/wrk/jsruntime-lib/src/main_bench.zig -Mjsruntime_build_options=/home/pierre/wrk/jsruntime-lib/zig-cache/c/934033f4bc0348c3ae7cb54f8a16aa41/options.zig -Mtigerbeetle-io=/home/pierre/wrk/jsruntime-lib/vendor/tigerbeetle-io/io.zig -I /home/pierre/wrk/jsruntime-lib/vendor/zig-v8/src -Mv8=/home/pierre/wrk/jsruntime-lib/vendor/zig-v8/src/v8.zig -lc++ --cache-dir /home/pierre/wrk/jsruntime-lib/zig-cache --global-cache-dir /home/pierre/.cache/zig --name jsruntime-bench --listen=- 
Build Summary: 1/4 steps succeeded; 1 failed (disable with --summary none)
bench transitive failure
└─ run jsruntime-bench transitive failure
   └─ zig build-exe jsruntime-bench Debug native 1 errors
error: the following build command failed with exit code 1:
/home/pierre/wrk/jsruntime-lib/zig-cache/o/b801f1d4b327a4cd9b4001a0456ccfe7/build /usr/local/zig/zig /home/pierre/wrk/jsruntime-lib /home/pierre/wrk/jsruntime-lib/zig-cache /home/pierre/.cache/zig --seed 0x99638d53 -Z685659b04bc68b48 bench -Dengine=v8
Build ERROR
make: *** [Makefile:133: build] Error 1
$ make test
Testing...
test
└─ run test
   └─ zig test Debug native 1 errors
/home/pierre/wrk/jsruntime-lib/src/run_tests.zig:48:30: error: global variable contains reference to comptime var
pub const Types = gen.reflect(gen.MergeTuple(.{
                  ~~~~~~~~~~~^
referenced by:
    Types: /home/pierre/wrk/jsruntime-lib/src/test_runner.zig:5:24
    Types: /home/pierre/wrk/jsruntime-lib/src/generate.zig:35:49
    remaining reference traces hidden; use '-freference-trace' to see all reference traces
error: the following command failed with 1 compilation errors:
/usr/local/zig/zig test /home/pierre/wrk/jsruntime-lib/vendor/v8/x86_64-linux/debug/libc_v8.a -fsingle-threaded -ODebug --dep jsruntime_build_options --dep tigerbeetle-io --dep v8 -Mroot=/home/pierre/wrk/jsruntime-lib/src/run_tests.zig -Mjsruntime_build_options=/home/pierre/wrk/jsruntime-lib/zig-cache/c/934033f4bc0348c3ae7cb54f8a16aa41/options.zig -Mtigerbeetle-io=/home/pierre/wrk/jsruntime-lib/vendor/tigerbeetle-io/io.zig -I /home/pierre/wrk/jsruntime-lib/vendor/zig-v8/src -Mv8=/home/pierre/wrk/jsruntime-lib/vendor/zig-v8/src/v8.zig -lc++ --test-runner /home/pierre/wrk/jsruntime-lib/src/test_runner.zig --cache-dir /home/pierre/wrk/jsruntime-lib/zig-cache --global-cache-dir /home/pierre/.cache/zig --name test --listen=- 
Build Summary: 1/4 steps succeeded; 1 failed (disable with --summary none)
test transitive failure
└─ run test transitive failure
   └─ zig test Debug native 1 errors
error: the following build command failed with exit code 1:
/home/pierre/wrk/jsruntime-lib/zig-cache/o/b801f1d4b327a4cd9b4001a0456ccfe7/build /usr/local/zig/zig /home/pierre/wrk/jsruntime-lib /home/pierre/wrk/jsruntime-lib/zig-cache /home/pierre/.cache/zig --seed 0xb4d1fc9e -Z32970297feafdb4c test -Dengine=v8
Test ERROR
make: *** [Makefile:155: test] Error 1

@krichprollsch krichprollsch marked this pull request as draft April 2, 2024 07:48
@krichprollsch krichprollsch changed the title Upgrade zig 0.12 [ON HOLD] Upgrade zig 0.12 Apr 3, 2024
@krichprollsch krichprollsch marked this pull request as ready for review June 12, 2024 14:30
@krichprollsch krichprollsch changed the title [ON HOLD] Upgrade zig 0.12 Upgrade zig 0.12.1 Jun 12, 2024
@krichprollsch krichprollsch force-pushed the upgrade-zig branch 2 times, most recently from cbbf269 to ac001fc Compare June 17, 2024 15:26
@krichprollsch krichprollsch merged commit d491f04 into main Jun 18, 2024
6 checks passed
@krichprollsch krichprollsch deleted the upgrade-zig branch June 18, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant