Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use all valid routes during blinded path construction #9334

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
+17 −32
Open

Use all valid routes during blinded path construction #9334

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c0d0044
blindedpath: add the MaxNumPaths restriction on BuildBlindedPaymentPaths
MPins Dec 5, 2024
b7741af
invoicesrpc: included MaxNumPaths to be used on BuildBlindedPaymentPaths
MPins Dec 5, 2024
e6f8f8d
routing: no MaxNumPaths restriction on FindBlindedPaths
MPins Dec 5, 2024
415eddd
routing: modify the TestFindBlindedPathsWithMC to not use MaxNumPaths
MPins Dec 13, 2024
cfa17cb
lnd: added MaxNumPaths on blindedPathCfg to be used on AddInvoice
MPins Dec 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 1 addition & 22 deletions routing/router_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3167,7 +3167,6 @@ func TestFindBlindedPathsWithMC(t *testing.T) {
dave, 1000, probabilitySrc, &BlindedPathRestrictions{
MinDistanceFromIntroNode: 2,
NumHops: 2,
MaxNumPaths: 3,
},
)
require.NoError(t, err)
Expand Down Expand Up @@ -3201,8 +3200,7 @@ func TestFindBlindedPathsWithMC(t *testing.T) {
}

// Now, let's lower the MC probability of the B-D to 0.5 and F-D link to
// 0.25. We will leave the MaxNumPaths as 3 and so all paths should
// still be returned but the order should be:
// 0.25:
// 1) A -> C -> D
// 2) A -> B -> D
// 3) A -> F -> D
Expand All @@ -3212,7 +3210,6 @@ func TestFindBlindedPathsWithMC(t *testing.T) {
dave, 1000, probabilitySrc, &BlindedPathRestrictions{
MinDistanceFromIntroNode: 2,
NumHops: 2,
MaxNumPaths: 3,
},
)
require.NoError(t, err)
Expand All @@ -3229,7 +3226,6 @@ func TestFindBlindedPathsWithMC(t *testing.T) {
dave, 1000, probabilitySrc, &BlindedPathRestrictions{
MinDistanceFromIntroNode: 2,
NumHops: 2,
MaxNumPaths: 3,
},
)
require.NoError(t, err)
Expand All @@ -3239,27 +3235,12 @@ func TestFindBlindedPathsWithMC(t *testing.T) {
"alice,charlie,dave",
})

// Change the MaxNumPaths to 1 to assert that only the best route is
// returned.
routes, err = ctx.router.FindBlindedPaths(
dave, 1000, probabilitySrc, &BlindedPathRestrictions{
MinDistanceFromIntroNode: 2,
NumHops: 2,
MaxNumPaths: 1,
},
)
require.NoError(t, err)
assertPaths(routes, []string{
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we still check here the expected number of paths now

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we could, but it would be redundant since this is already tested in the previous tests.

"alice,bob,dave",
})

// Test the edge case where Dave, the recipient, is also the
// introduction node.
routes, err = ctx.router.FindBlindedPaths(
dave, 1000, probabilitySrc, &BlindedPathRestrictions{
MinDistanceFromIntroNode: 0,
NumHops: 0,
MaxNumPaths: 1,
},
)
require.NoError(t, err)
Expand All @@ -3274,7 +3255,6 @@ func TestFindBlindedPathsWithMC(t *testing.T) {
dave, 1000, probabilitySrc, &BlindedPathRestrictions{
MinDistanceFromIntroNode: 2,
NumHops: 2,
MaxNumPaths: 3,
},
)
require.NoError(t, err)
Expand All @@ -3289,7 +3269,6 @@ func TestFindBlindedPathsWithMC(t *testing.T) {
dave, 1000, probabilitySrc, &BlindedPathRestrictions{
MinDistanceFromIntroNode: 2,
NumHops: 2,
MaxNumPaths: 3,
NodeOmissionSet: fn.NewSet(frank),
},
)
Expand Down