Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Beat [5/4]: fix itests for blockbeat #9227

Draft
wants to merge 32 commits into
base: yy-blockbeat-finalize
Choose a base branch
from
Draft

Beat [5/4]: fix itests for blockbeat #9227

wants to merge 32 commits into from

Conversation

yyforyongyu
Copy link
Member

Pushed to trigger CI.

TODO: add a description here

@yyforyongyu yyforyongyu added itests Issues related to integration tests. size/mega large, significant context needed, over 1000 lines labels Oct 28, 2024
@yyforyongyu yyforyongyu self-assigned this Oct 28, 2024
@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 28, 2024 •
edited
Loading

Important

Review skipped

Auto reviews are limited to specific labels.

🏷️ Labels to auto review (1)
  • llm-review

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

This was referenced Oct 28, 2024
Merged
Open
@yyforyongyu
lntest: make sure minRelayFeerate is reset
af2e916 
So every test starts with the default minRelayFeerate.
@yyforyongyu
lntest: make sure standby nodes' edges are cleaned
87c1190
@yyforyongyu
itest: fix testZeroConfChannelOpen and testOptionScidAlias
e050a75 
Use a new node instead of standby node to avoid closing the channels in
the end.
@yyforyongyu
lntest+itest: expore method createSimpleNetwork
6756821 
So it can be used via `ht.CreateSimpleNetwork`.
@yyforyongyu
lntest+itest: fix testUpdateChanStatus
b678dc0
@yyforyongyu
multi: optimize loggings around changes from blockbeat
a5fec2e
@yyforyongyu
lntest+itest: fix testSweepCPFPAnchorOutgoingTimeout
c5a5ff9
@yyforyongyu
itest: fix testSweepCPFPAnchorIncomingTimeout
526321d
@yyforyongyu
itest: fix testSweepHTLCs`
ac1d93c
@yyforyongyu
itest: fix testSweepCommitOutputAndAnchor
b49a534
@yyforyongyu
itest: fix testBumpForceCloseFee
9ad451d
@yyforyongyu
itest: fix testPaymentSucceededHTLCRemoteSwept
960cdab
@yyforyongyu
lntest+itest: start flattening the multi-hop tests
a57645e 
Starting from this commit, we begin the process of flattening the
multi-hop itests to make them easier to be maintained. The tests are
refactored into their own test cases, with each test focusing on testing
one channel type. This is necessary to save effort for future
development.

These tests are also updated to reflect the new `blockbeat` behavior.
@yyforyongyu
itest: simplify and flatten testMultiHopReceiverChainClaim
b205884
@yyforyongyu
lntest+itest: flatten testMultiHopLocalForceCloseOnChainHtlcTimeout
e7f8ada
@yyforyongyu
lntest+itest: flatten testMultiHopRemoteForceCloseOnChainHtlcTimeout
3ac03f5
@yyforyongyu
itest: flatten testMultiHopHtlcLocalChainClaim
1bbacad
@yyforyongyu
itest: flatten testMultiHopHtlcRemoteChainClaim
8639dd5
@yyforyongyu
itest: flatten testMultiHopHtlcAggregation
0416156
@yyforyongyu
itest: flatten testHtlcTimeoutResolverExtractPreimageLocal
32b84f0 
This commit simplfies the test since we only test the preimage
extraction logic in the htlc timeout resolver, there's no need to test
it for all different channel types as the resolver is made to be
oblivious about them.
@yyforyongyu
itest: flatten testHtlcTimeoutResolverExtractPreimageRemote
f09d485 
Also remove unused code.
@yyforyongyu
itest: rename file to reflect the tests
18cddb1
@yyforyongyu
itest: remove unnecessary force close
57b89e7
This was referenced Oct 29, 2024
Open
Draft
@yyforyongyu yyforyongyu added this to the v0.19.0 milestone Oct 29, 2024
@ziggie1984 ziggie1984 self-requested a review November 5, 2024 12:15
@yyforyongyu yyforyongyu mentioned this pull request Nov 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ziggie1984 ziggie1984 Awaiting requested review from ziggie1984

Assignees

@yyforyongyu yyforyongyu

Labels
itests Issues related to integration tests. size/mega large, significant context needed, over 1000 lines
Projects
lnd v0.19
Status: No status
Milestone
v0.19.0
Development

Successfully merging this pull request may close these issues.
1 participant
@yyforyongyu