-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
multi: route blinding for hodl invoices #9034
base: master
Are you sure you want to change the base?
multi: route blinding for hodl invoices #9034
Conversation
Important Review skippedAuto reviews are limited to specific labels. Labels to auto review (1)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Labeling as Micro review load since this does not require any route blinding knowledge/context. All this does is a bit of refactor of the AddInvoice flow to make the same stuff re-usable for AddHoldInvoice |
We will use it again once we add blinded path support to hold invoices.
To make it reusable when we add support to hold invoices.
d273344
to
0b16e81
Compare
So that they are re-usable for other commands.
0b16e81
to
d2d9f3a
Compare
@ellemouton, remember to re-request review from reviewers when ready |
Adds route blinding receive functionality to hodl invoices.
Fixes #9024