-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LightningPayment
first hop custom records
#8656
Closed
GeorgeTsagk
wants to merge
10
commits into
lightningnetwork:master
from
GeorgeTsagk:payment-firsthop-records
Closed
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
40f32b0
multi: improve comment grammar
ffranr c9c7304
htlcswitch: add missing method doc
ffranr 103a671
record: add encode and decode methods to `CustomSet`
ffranr 75bc4ae
lnwire: add custom records blob field to type `UpdateAddHtlc`
ffranr 74d5b57
htlcswitch: add resume modified HTLC action to switch
ffranr bea7e44
routerrpc: extend HTLC forward interceptor resp with modification fields
ffranr 2d70c13
itest: add itest for field modification HTLC interception response
ffranr 6b4ba1c
lnrpc: add first hop records field to SendPayment
GeorgeTsagk 5260069
routing: encode first hop records in update_add_htlc message
GeorgeTsagk c092a65
itest: add first hop records interceptor test
GeorgeTsagk File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So I chatted with @ffranr about this offline, but instead we only want to be setting
ExtraData
. All the other logic (further down in the state machine), will only look inside ofExtraData
, as it isn't expecting that extra layer of wrapping.We do want the upfront validation here tho to ensure that w/e we're passed in is actually a canonical TLV stream.