Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release notes for 0.17 updated to the new format #7907

Merged
merged 1 commit into from
Aug 23, 2023

Conversation

saubyk
Copy link
Collaborator

@saubyk saubyk commented Aug 23, 2023

Added a table of contents at the top and various sections to navigate to, to make it easy to parse and read the release notes.

Change Description

Description of change / link to associated issue.

Steps to Test

Steps for reviewers to follow to test the change.

Pull Request Checklist

Testing

  • Your PR passes all CI checks.
  • Tests covering the positive and negative (error paths) are included.
  • Bug fixes contain tests triggering the bug to prevent regressions.

Code Style and Documentation

📝 Please see our Contribution Guidelines for further guidance.

@saubyk saubyk added documentation Documentation changes that do not affect code behaviour no-itest no-changelog labels Aug 23, 2023
@saubyk saubyk added this to the v0.17.0 milestone Aug 23, 2023
@saubyk saubyk requested a review from Roasbeef August 23, 2023 02:14
@saubyk saubyk self-assigned this Aug 23, 2023
@github-actions
Copy link

Pull reviewers stats

Stats of the last 30 days for lnd:

User Total reviews Time to review Total comments
guggero
🥇
11
▀▀▀
1d 8h 21m
23
▀▀▀▀▀
yyforyongyu
🥈
10
▀▀▀
1d 20h 56m
9
▀▀
Roasbeef
🥉
3
4d 10h 3m
▀▀
3
ellemouton
3
6d 18h 11m
▀▀▀
0
ProofOfKeags
2
2d 5h
1
morehouse
2
1d 2m
3
positiveblue
1
5h 1m
0
Crypt-iQ
1
1d 1h 55m
1
saubyk
1
7h 15m
0
blckbx
1
50m
2
ziggie1984
1
20h 48m
3

@saubyk saubyk changed the title Release notes updated to the new format Release notes for 0.17 updated to the new format Aug 23, 2023
@Roasbeef
Copy link
Member

Needs a rebase!

Added a table of contents at the top and various sections to navigate to, to make it easy to parse and read the release notes.
@saubyk
Copy link
Collaborator Author

saubyk commented Aug 23, 2023

Needs a rebase!

Done

Copy link
Member

@Roasbeef Roasbeef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💾

Looks good to be as a first pass, I think some of the sections that have None could be populated, but then we'd also have some duplication elsewhere. So I guess we need to think about which headings have priority over others.

@Roasbeef Roasbeef merged commit c07ec04 into master Aug 23, 2023
17 of 18 checks passed
@yyforyongyu yyforyongyu deleted the 17-release-notes-reformat branch August 24, 2023 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Documentation changes that do not affect code behaviour no-changelog no-itest
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants