Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

multi: use filepath instead of path to support Windows #422

Merged
merged 1 commit into from
Jul 27, 2023
Merged

multi: use filepath instead of path to support Windows #422

merged 1 commit into from
Jul 27, 2023

Conversation

guggero
Copy link
Member

@guggero guggero commented Jul 27, 2023

Fixes #421.

@guggero guggero requested review from ffranr and jharveyb July 27, 2023 08:29
ffranr
ffranr approved these changes Jul 27, 2023
View reviewed changes
Copy link
Contributor

@ffranr ffranr left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

I suppose we could also just change to

import (
    path "path/filepath"
)

Roasbeef
Roasbeef approved these changes Jul 27, 2023
View reviewed changes
Copy link
Member

@Roasbeef Roasbeef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🔥

@Roasbeef Roasbeef added this pull request to the merge queue Jul 27, 2023
Merged via the queue into main with commit 429b3ea Jul 27, 2023
13 checks passed
@guggero guggero deleted the path-vs-filepath branch July 27, 2023 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ffranr ffranr ffranr approved these changes

@Roasbeef Roasbeef Roasbeef approved these changes

@jharveyb jharveyb Awaiting requested review from jharveyb

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[bug]: ImportProofs failed because of proof path error on Windows
3 participants
@guggero @Roasbeef @ffranr