Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move importproof RPC endpoint into new tapdev RPC server #420

Merged
merged 3 commits into from
Jul 27, 2023
Merged

Move importproof RPC endpoint into new tapdev RPC server #420

merged 3 commits into from
Jul 27, 2023

Conversation

ffranr
Copy link
Contributor

@ffranr ffranr commented Jul 26, 2023

This PR fixes: #395

guggero
guggero reviewed Jul 27, 2023
View reviewed changes
Copy link
Member

@guggero guggero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Have a couple of small comments, should be pretty easy to address.

taprpc/tapdevrpc/tapdev.yaml Outdated Show resolved Hide resolved
taprpc/tapdevrpc/tapdev.swagger.json Show resolved Hide resolved
cmd/tapcli/tapdevrpc_active.go Outdated Show resolved Hide resolved
cmd/tapcli/tapdevrpc_active.go Outdated Show resolved Hide resolved
@ffranr ffranr requested a review from guggero July 27, 2023 13:32
positiveblue
positiveblue approved these changes Jul 27, 2023
View reviewed changes
Copy link
Contributor

@positiveblue positiveblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Not sure if all the commits building is a must, if so we may have to rearange some of the changes to be sure that we do not import things that do not exist.

taprpc/tapdevrpc/config_active.go Show resolved Hide resolved
@guggero guggero added this pull request to the merge queue Jul 27, 2023
Merged via the queue into lightninglabs:main with commit b40bfa9 Jul 27, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@positiveblue positiveblue positiveblue approved these changes

@guggero guggero guggero approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[enhancement]: Designate ImportProof RPC endpoint as debug only
3 participants
@ffranr @guggero @positiveblue