Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rpcserver: add missing merkle root and tapscript sibling fields to DecodeProof RPC #408

Merged
merged 2 commits into from
Jul 19, 2023
Merged

rpcserver: add missing merkle root and tapscript sibling fields to DecodeProof RPC #408

merged 2 commits into from
Jul 19, 2023

Conversation

guggero
Copy link
Member

@guggero guggero commented Jul 19, 2023

Fixes #407.

@guggero guggero added the v0.2.3 label Jul 19, 2023
@guggero guggero requested review from ffranr and jharveyb July 19, 2023 09:48
jharveyb
jharveyb approved these changes Jul 19, 2023
View reviewed changes
Copy link
Collaborator

@jharveyb jharveyb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; manually verified by adding a print of the decoded & formatted proof in itest/assertions:verifyProofBlob()

@guggero guggero added this pull request to the merge queue Jul 19, 2023
@guggero guggero mentioned this pull request Jul 19, 2023
Merged
Merged via the queue into main with commit a543767 Jul 19, 2023
@guggero guggero deleted the decode-proof branch July 19, 2023 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jharveyb jharveyb jharveyb approved these changes

@ffranr ffranr ffranr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Taproot-Assets Project Board
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[bug]: /proofs/decode returns null for raw_group_key & merkle_root
3 participants
@guggero @ffranr @jharveyb