Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tapcli: fix flag checking for universe proof cmds #397

Merged
merged 1 commit into from
Jul 13, 2023

Conversation

jharveyb
Copy link
Collaborator

@jharveyb jharveyb commented Jul 12, 2023

Addresses issues from #308 that are fixable while using urfave/cli v1.

copilot:all

Fixes #308

@jharveyb jharveyb requested review from guggero and ffranr July 12, 2023 17:57
@Roasbeef
Copy link
Member

copilot:all

Copy link
Member

@Roasbeef Roasbeef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🦚

@Roasbeef Roasbeef added this pull request to the merge queue Jul 13, 2023
Merged via the queue into main with commit 9c8d7b1 Jul 13, 2023
12 checks passed
@guggero guggero deleted the universe_cli_improvements branch July 13, 2023 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Misc. wrinkles with Universe CLI cmds
4 participants