Improve universe stats #396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guggero
force-pushed
the
asset-stats-improvements
branch
3 times, most recently
from
47cac50
to
cb9b7e2
Compare
jharveyb
approved these changes
Jul 14, 2023
guggero
force-pushed
the
asset-stats-improvements
branch
from
cb9b7e2
to
cdee934
Compare
ffranr
reviewed
Jul 14, 2023
There was a problem hiding this comment.
There's a lot of work here, good job Oli on getting it together!
I would question whether we need to aggregate the events data at all. Or at least whether it makes sense to aggregate by day. That seems like the sort of thing we could just ask a client to do for the time being.
If we are to aggregate, I wonder if we could just keep the aggregation window as an argument.
I see that the terminal team requested this level of aggregation (5 here: #367)
In a next commit we'll want to be able to better test asset events which are always inserted into the DB with a timestamp of `time.Now()`. In order to be able to influence what time is actually written to the DB, we use the `clock.Now()` value that can be overwritten in unit tests.
guggero
force-pushed
the
asset-stats-improvements
branch
from
cdee934
to
e39d07b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #389.Fixes #367.
This PR addresses items 2, 3, 4 and 5 of #367.
@jamaljsr can you please check if this is what you need?