Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

itest: add missing build tag #377

Closed
wants to merge 1 commit into from
Closed

itest: add missing build tag #377

wants to merge 1 commit into from

Conversation

jharveyb
Copy link
Collaborator

Avoid building itests when building for a release.

@guggero
Copy link
Member

guggero commented Jun 23, 2023

I don't think we should add build tags to each file, as that makes it a bit harder to use (for example, the itest files aren't compiled anymore when running the unit tests, which is sometimes handy to detect compilation errors early).
Because the release binary shouldn't have any reference to the itest package at all, it will not be built by default.
So something is wrong and the offender seems to be proof/aperture.go. That needs to be moved to the itest package, then we resolve the original issue.

@guggero
Copy link
Member

guggero commented Jun 23, 2023

Replaced by #378.

@guggero guggero closed this Jun 23, 2023
@jharveyb jharveyb deleted the itest_build_tagging branch July 5, 2023 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants