Preliminary refactor in preparation for adding multiverse support #346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Roasbeef
reviewed
Jun 8, 2023
ffranr
force-pushed
the
refactor-universe
branch
3 times, most recently
from
b5942f7
to
9c4b9b4
Compare
Roasbeef
reviewed
Jun 16, 2023
universe/interface.go
Outdated
| @@ -194,6 +194,10 @@ type BaseForest interface { | |||
| // of assets tracked in the base Universe. | |||
| RootNodes(ctx context.Context) ([]BaseRoot, error) | |||
|
|
|||
| RegisterIssuance(ctx context.Context, id Identifier, key BaseKey, | |||
There was a problem hiding this comment.
Doesn't need to be done now, but eventually we'll also want to distinguish from the a multi-verse of only issuance, from one of all transfers for an asset, from one of all transfers for any asset.
Also notice the other BaseUniverse interface doesn't actually take an ID as it's bound to that asset id or group key. As this is a base multi-verse/forst, I think we'd also want to carry that over. You'd then have something similar to the current base uni struct here that is able to fetch the multiverse needed for the action.
ffranr
force-pushed
the
refactor-universe
branch
4 times, most recently
from
397747e
to
3af30e2
Compare
|
I don't intend on adding more to this PR (except when responding to reviews). I think it's good to go as a refactoring PR. I'll make other PRs for the rest of the work. |
ffranr
force-pushed
the
refactor-universe
branch
from
3af30e2
to
6ab36c7
Compare
guggero
approved these changes
Jun 26, 2023
This was referenced Jul 5, 2023
ffranr
force-pushed
the
refactor-universe
branch
from
43eaf0e
to
742f12e
Compare
jharveyb
approved these changes
Jul 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preliminary refactor PR made in an attempt to split up the work a bit.