Skip to content

docs: add support for asset group key in price oracle #1579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 2, 2025

Conversation

ffranr
Copy link
Contributor

@ffranr ffranr commented May 31, 2025

Extend the price oracle to support requests using an asset group key.

Refactor by renaming two functions and extracting constants to make supported asset IDs and asset group keys easier to locate and modify.

cc @Liongrass

Extend the price oracle to support requests using an asset group key.

Refactor by renaming two functions and extracting constants to make
supported asset IDs and asset group keys easier to locate and modify.
@ffranr ffranr self-assigned this May 31, 2025
@ffranr ffranr added documentation Improvements or additions to documentation testing oracle labels May 31, 2025
@coveralls
Copy link

Pull Request Test Coverage Report for Build 15364888773

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 37 unchanged lines in 6 files lost coverage.
  • Overall coverage decreased (-0.03%) to 37.112%

Files with Coverage Reduction New Missed Lines %
asset/group_key.go 2 57.89%
tappsbt/create.go 2 26.74%
address/address.go 6 67.47%
commitment/tap.go 6 71.36%
tapgarden/caretaker.go 7 68.21%
address/mock.go 14 88.24%
Totals Coverage Status
Change from base Build 15328080809: -0.03%
Covered Lines: 26971
Relevant Lines: 72675

💛 - Coveralls

Copy link
Member

@guggero guggero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM 🎉

@ffranr ffranr requested a review from GeorgeTsagk June 2, 2025 09:14
@GeorgeTsagk GeorgeTsagk added this pull request to the merge queue Jun 2, 2025
Merged via the queue into main with commit 4476e7d Jun 2, 2025
18 checks passed
@guggero guggero deleted the basic-price-oracle-group-key branch June 2, 2025 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation oracle testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants