Add 'include_leased' flag to ListBalances #1119
Merged
+1,156
−684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 10973284227Details
💛 - Coveralls |
guggero
requested changes
Sep 16, 2024
gijswijs
force-pushed
the
asset-balance-alignment
branch
from
a70845a
to
0aa9037
Compare
guggero
reviewed
Sep 19, 2024
guggero
approved these changes
Sep 20, 2024
This commit adds 'include_leased' flag to `ListBalances` rpc endpoint. With this flag you show balances that include the leased assets, which are otherwise ignored.
Since we now have the same flags for the `ListAssets` and `ListBalances` calls, we add a check that makes sure the sum of all assets returned by `ListAssets` matches the sum returned in `ListBalances`.
With this commit, we add a unit test for the `QueryBalancesByAsset` and `QueryAssetBalancesByGroup` funcs. The test checks that those balance queries return the expected results with all sorts of grouped and leased assets combined, and with the `includeLeased` flag on and off.
gijswijs
force-pushed
the
asset-balance-alignment
branch
from
ff6b49c
to
fad2631
Compare
GeorgeTsagk
approved these changes
Sep 21, 2024
| @@ -1913,7 +1913,9 @@ func AssertAssetBalances(t *testing.T, client taprpc.TaprootAssetsClient, | |||
|
|
|||
| require.Equal(t, len(allAssets), len(assetIDBalances.AssetBalances)) | |||
|
|
|||
| var totalBalance uint64 | |||
There was a problem hiding this comment.
nit: shouldn't this commit precede the previous itest: test balances with an without leased flag
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
include_leasedflag to ListBalances rpc endpoint.With this flag you show balances that include the leased assets, which are otherwise ignored. In doing so the behavior is now synced with the
ListAssetsendpoint.Fixes #1106 task 2 (2nd checkbox, and probably also 1st checkbox)
Fixes #1106