Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Server logging cleanup #1110

Merged
merged 2 commits into from
Aug 27, 2024
Merged

Server logging cleanup #1110

merged 2 commits into from
Aug 27, 2024

Conversation

ffranr
Copy link
Contributor

@ffranr ffranr commented Aug 27, 2024

I noticed that user log files were unnecessarily verbose, therefore, this PR downgrades some log messages from info to trace.

@ffranr ffranr self-assigned this Aug 27, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 10578226486

Details

  • 0 of 8 (0.0%) changed or added relevant lines in 1 file are covered.
  • 23 unchanged lines in 5 files lost coverage.
  • Overall coverage decreased (-0.02%) to 40.306%

Changes Missing Coverage Covered Lines Changed/Added Lines %
server.go 0 8 0.0%
Files with Coverage Reduction New Missed Lines %
tappsbt/create.go 2 53.22%
tapdb/universe.go 4 80.91%
tapgarden/caretaker.go 4 68.5%
asset/asset.go 4 81.61%
universe/interface.go 9 47.09%
Totals Coverage Status
Change from base Build 10534107048: -0.02%
Covered Lines: 23958
Relevant Lines: 59440

💛 - Coveralls

Copy link
Collaborator

@dstadulis dstadulis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

implementation ack/lgtm


srvrLog.Infof("Active network: %v", s.cfg.ChainParams.Name)
"debuglevel=%s, active_network=%v", Version(), build.Deployment,
build.LoggingType, s.cfg.DebugLevel, s.cfg.ChainParams.Name)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹

@guggero guggero merged commit 4556837 into main Aug 27, 2024
17 checks passed
@guggero guggero deleted the server-logging-cleanup branch August 27, 2024 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

4 participants