Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept price deviation ppm configuration #1109

Merged

Conversation

lukegao209
Copy link
Contributor

No description provided.

@guggero
Copy link
Member

guggero commented Aug 27, 2024

You don't need to open new pull requests for each change... You can just change the commits with some git rebase commands: https://hackernoon.com/beginners-guide-to-interactive-rebasing-346a3f9c3a6d

@coveralls
Copy link

Pull Request Test Coverage Report for Build 10575567794

Details

  • 0 of 9 (0.0%) changed or added relevant lines in 3 files are covered.
  • 26 unchanged lines in 5 files lost coverage.
  • Overall coverage decreased (-0.006%) to 40.319%

Changes Missing Coverage Covered Lines Changed/Added Lines %
rfq/manager.go 0 1 0.0%
tapcfg/server.go 0 2 0.0%
tapcfg/config.go 0 6 0.0%
Files with Coverage Reduction New Missed Lines %
tappsbt/create.go 2 53.22%
tapgarden/caretaker.go 4 68.5%
commitment/tap.go 4 84.43%
asset/asset.go 4 81.61%
universe/interface.go 12 50.22%
Totals Coverage Status
Change from base Build 10534107048: -0.006%
Covered Lines: 23969
Relevant Lines: 59449

💛 - Coveralls

@lukegao209
Copy link
Contributor Author

You don't need to open new pull requests for each change... You can just change the commits with some git rebase commands: https://hackernoon.com/beginners-guide-to-interactive-rebasing-346a3f9c3a6d

I’m not very familiar with Go and the project conventions yet, but I’ll get better at it moving forward

@dstadulis
Copy link
Collaborator

Thanks for the code contribution! As mentioned, rebasing the PRs will make tracking the change requests easiest for everyone.

This'll be a helpful feature!

Copy link
Member

@guggero guggero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM 🎉 Going to squash commits on merge.

@guggero guggero merged commit dbb6724 into lightninglabs:main Aug 27, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

4 participants