Enhance Proof Delivery Resilience with ParSliceErrCollect in ChainPorter #1100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ffranr
force-pushed
the
robust-multi-proof-delivery
branch
from
94362fd
to
55c9d3b
Compare
ffranr
changed the title
Pull Request Test Coverage Report for Build 10579893055Details
💛 - Coveralls |
|
PR Ensures proofs are delivered given partial proof-courier addresses availability |
guggero
reviewed
Aug 23, 2024
fn/concurrency.go
Outdated
| instanceErrors := make(map[int]error, len(s)) | ||
|
|
||
| for idx, v := range s { | ||
| v := v |
There was a problem hiding this comment.
nit: this is no longer required, as we're now using Go 1.22.
There was a problem hiding this comment.
I've gone with s[idx] in the latest commits. Are you saying that v := v isn't required because of Go 1.22? Why is that, can you say more please?
There was a problem hiding this comment.
jharveyb
reviewed
Aug 26, 2024
Add ParSliceErrCollect function to handle errors without halting parallel processing. ParSliceErrCollect is similar to ParSlice but allows processing to continue even when errors occur. Instead of halting on the first error, it collects all errors for later handling, providing more robust parallel execution.
This commit adds the `PeekMap` function. This function non-deterministically selects and returns a single key-value pair from the given map.
This commit leverages the new ParSliceErrCollect function to process transfer output proofs in parallel. This change ensures that processing continues even if a transfer output proof delivery instance fails.
ffranr
force-pushed
the
robust-multi-proof-delivery
branch
from
55c9d3b
to
ac10515
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the proof delivery process in
ChainPorterby utilizing the newly introducedParSliceErrCollectfunction. This change ensures that proof delivery continues even if an individual transfer output proof encounters an error, improving the reliability of the delivery process.This change ensures that as many transfer output proofs as possible are delivered, even in the presence of errors.
Changes
ParSliceErrCollect, which collects errors during parallel processing without halting the entire operation.ParSliceErrCollectfor parallel proof delivery, allowing the process to continue despite individual delivery failures.Related to: #1082