Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize Parcel Resumption and Reduce Blocking in ChainPorter #1068

Closed
wants to merge 3 commits into from
Closed

Optimize Parcel Resumption and Reduce Blocking in ChainPorter #1068

wants to merge 3 commits into from

Commits on Aug 8, 2024

  1. tapfreighter: reposition WaitGroup.Done() call for better clarity 

    This commit moves the WaitGroup.Done() call closer to the corresponding
WaitGroup.Add(1) call. The purpose of this change is to group the
goroutine management code together, making it easier to read and
reducing the risk of forgetting to decrement the WaitGroup counter.
    @ffranr
    ffranr committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    6e3ffae View commit details
    Browse the repository at this point in the history

  2. tapfreighter: buffer outboundParcels channel to prevent blocking 

    This commit introduces a buffer to the ChainPorter.outboundParcels
channel. By adding this buffer, the system can handle new parcels
without being blocked by resumed pending parcels, improving overall
efficiency and reducing potential delays.
    @ffranr
    ffranr committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    b9b3062 View commit details
    Browse the repository at this point in the history

  3. tapfreighter: exec ChainPorter.resumePendingParcels in new goroutine 

    Resume any pending parcels in a new goroutine so that we don't delay
returning from the `ChainPorter.Start` method.
    @ffranr
    ffranr committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    9ac1baa View commit details
    Browse the repository at this point in the history