Merge pull request #369 from Roasbeef/fix-log-dir

tapcfg: ensure log rotator created after config validation

tapcfg/config.go

@@ -414,17 +414,6 @@ func LoadConfig(interceptor signal.Interceptor) (*Config, btclog.Logger, error)
 		return nil, nil, err
 	}
 
-	// Initialize logging at the default logging level.
-	tap.SetupLoggers(cfg.LogWriter, interceptor)
-	err = cfg.LogWriter.InitLogRotator(
-		filepath.Join(cfg.LogDir, defaultLogFilename),
-		cfg.MaxLogFileSize, cfg.MaxLogFiles,
-	)
-	if err != nil {
-		_, _ = fmt.Fprintln(os.Stderr, err.Error())
-		return nil, nil, err
-	}
-
 	cfgLogger := cfg.LogWriter.GenSubLogger("CONF", nil)
 
 	// Make sure everything we just loaded makes sense.
@@ -439,6 +428,17 @@ func LoadConfig(interceptor signal.Interceptor) (*Config, btclog.Logger, error)
 		return nil, nil, err
 	}
 
+	// Initialize logging at the default logging level.
+	tap.SetupLoggers(cfg.LogWriter, interceptor)
+	err = cfg.LogWriter.InitLogRotator(
+		filepath.Join(cleanCfg.LogDir, defaultLogFilename),
+		cleanCfg.MaxLogFileSize, cfg.MaxLogFiles,
+	)
+	if err != nil {
+		_, _ = fmt.Fprintln(os.Stderr, err.Error())
+		return nil, nil, err
+	}
+
 	// Warn about missing config file only after all other configuration is
 	// done. This prevents the warning on help messages and invalid
 	// options.  Note this should go directly before the return.