Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add openchannel reserve option #186

Conversation

GeorgeTsagk
Copy link
Member

Description

This PR adds an optional argument to the open channel request for the remote reserve amount.

@GeorgeTsagk GeorgeTsagk self-assigned this Jun 6, 2024
@GeorgeTsagk GeorgeTsagk changed the base branch from master to custom-channels-integration June 6, 2024 17:32
@GeorgeTsagk
Copy link
Member Author

Not sure why we're hitting
https://github.com/lightninglabs/lndclient/actions/runs/9405322822/job/25906215580?pr=186#step:5:14

go.mod:187: invalid go version '1.21.4': must match format 1.23

@GeorgeTsagk GeorgeTsagk force-pushed the add-openchannel-reserve-option branch from a917d5a to 5dc648b Compare June 6, 2024 18:24
@guggero
Copy link
Member

guggero commented Jun 6, 2024

The branch you're merging into doesn't have a PR yet, so I haven't looked into the linter. Probably just need to update the Go version.

@guggero guggero merged commit 3bf71f8 into lightninglabs:custom-channels-integration Jun 6, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

[enhancement]: Channel-state machine initiation stalls due to channel-reserve requirement
3 participants