Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lnc-core: update version to v0.3.3-alpha #38

Merged
merged 4 commits into from
Jan 23, 2025
Merged

lnc-core: update version to v0.3.3-alpha #38

merged 4 commits into from
Jan 23, 2025

Conversation

jamaljsr
Copy link
Member

@jamaljsr jamaljsr commented Aug 16, 2024 •
edited
Loading

This PR bumps lnc-core to v0.3.2-alpha, updating the protos for each daemon:

  • lnd v0.18.4-beta
  • loop v0.29.0-beta
  • tapd v0.5.0
  • lit v0.14.0-alpha

Depends on

@jamaljsr jamaljsr force-pushed the 0-19-staging branch 2 times, most recently from ce854ee to 88d4534 Compare September 11, 2024 04:23
@jamaljsr jamaljsr marked this pull request as ready for review January 14, 2025 05:47
@jamaljsr jamaljsr changed the title [WIP] Add support for new TAP channel RPCs Add support for new TAP channel RPCs Jan 14, 2025
ViktorTigerstrom
ViktorTigerstrom approved these changes Jan 16, 2025
View reviewed changes
Copy link
Collaborator

@ViktorTigerstrom ViktorTigerstrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good 🚀!
Though given that this is targeting the 0-19-staging branch, should we instead wait for the LNC release, and then make it instead target main, and also then include a version bump of lnc-core?

package.json Outdated Show resolved Hide resolved
@jamaljsr
Copy link
Member Author

Though given that this is targeting the 0-19-staging branch, should we instead wait for the LNC release, and then make it instead target main, and also then include a version bump of lnc-core?

Yes, I would wait for a tagged release of LNC, then bump the version numbers to match, before merging this PR.

Apologies, I probably should have waited before requesting review.

@jamaljsr jamaljsr self-assigned this Jan 23, 2025
@jamaljsr
Copy link
Member Author

@ViktorTigerstrom this should be good to go now.

ViktorTigerstrom
ViktorTigerstrom approved these changes Jan 23, 2025
View reviewed changes
Copy link
Collaborator

@ViktorTigerstrom ViktorTigerstrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK, LGTM! Only question is if we should include the version bump in this PR or if we should do that in a separate one

package.json Show resolved Hide resolved
@jamaljsr jamaljsr changed the title Add support for new TAP channel RPCs lnc-core: update version to v0.3.3-alpha Jan 23, 2025
@ViktorTigerstrom ViktorTigerstrom merged commit b04a8d0 into main Jan 23, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ViktorTigerstrom ViktorTigerstrom ViktorTigerstrom approved these changes

Assignees

@jamaljsr jamaljsr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jamaljsr @ViktorTigerstrom