config+terminal: allow configuring of lnd RPC timeout #899
Conversation
terminal.go
Outdated
| @@ -74,6 +74,7 @@ const ( | |||
|
|
|||
| defaultServerTimeout = 10 * time.Second | |||
| defaultConnectTimeout = 15 * time.Second | |||
| defaultRPCTimeout = 1 * time.Minute | |||
There was a problem hiding this comment.
The actual default timeout used in lndclient lnd_services.go is 30 seconds:
https://github.com/lightninglabs/lndclient/blob/d89c44c7ef25fdf72c901876b6961ebee7d0c133/lnd_services.go#L30
Would we like to mimic that in litd, or would we specifically like to set it to 1 minute in litd?
There was a problem hiding this comment.
Yes, this is an intentional bump. 30 seconds probably is too low already, especially looking at your other comment. Perhaps we should bump it even more?
There was a problem hiding this comment.
Thanks for clarifying!
Perhaps we should bump it even more?
Yeah maybe it'd make sense to bump it to 2 or 3 minutes even. Though I'd be ok with setting this default to 1 minute for now, and adjust it in future if needed. Feel free to set this to whatever you'd prefer of those alternatives :)!
There was a problem hiding this comment.
Okay, I bumped it to 3 minutes. Since we'll soon have more involved startup dependencies (lnd -> tapd -> lnd), having more time available to resolve things should help.
guggero
force-pushed
the
lndclient-timeout
branch
2 times, most recently
from
fd7a572
to
5ab7d62
Compare
terminal.go
Outdated
| @@ -74,6 +74,7 @@ const ( | |||
|
|
|||
| defaultServerTimeout = 10 * time.Second | |||
| defaultConnectTimeout = 15 * time.Second | |||
| defaultRPCTimeout = 1 * time.Minute | |||
There was a problem hiding this comment.
Thanks for clarifying!
Perhaps we should bump it even more?
Yeah maybe it'd make sense to bump it to 2 or 3 minutes even. Though I'd be ok with setting this default to 1 minute for now, and adjust it in future if needed. Feel free to set this to whatever you'd prefer of those alternatives :)!
guggero
force-pushed
the
lndclient-timeout
branch
from
5ab7d62
to
12b3730
Compare
Allows the RPC timeout for the single
lndclientinstance that's given to all subservers to be configured.Related to lightninglabs/taproot-assets#1177.