Batch forwarding followup #3955
Conversation
We limit the tail latency of our batch forwarding delay.
We previously introduced an additional `loop_exit_check` in background processor. Since all reviewers seemed to be skeptical about its usefulness, we drop it again here.
|
👋 Thanks for assigning @TheBlueMatt as a reviewer! |
.. as requested on the original PR, we combine the two `sleeper` futures into a single one.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3955 +/- ##
==========================================
+ Coverage 88.74% 88.91% +0.16%
==========================================
Files 172 173 +1
Lines 123275 123387 +112
Branches 123275 123387 +112
==========================================
+ Hits 109399 109708 +309
+ Misses 11495 11218 -277
- Partials 2381 2461 +80
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| @@ -399,13 +399,6 @@ macro_rules! define_run_body { | |||
| last_forwards_processing_call = $get_timer(cur_batch_delay); | |||
| } | |||
|
|
|||
| // Checke whether to exit the loop again, as some time might have passed since we | |||
| // checked above. | |||
| if $loop_exit_check { | |||
There was a problem hiding this comment.
I think this is the wrong one to drop. We should check for exit right before we do the long sleep below, not before we forward and then do the long-sleep.
|
👋 The first review has been submitted! Do you think this PR is ready for a second reviewer? If so, click here to assign a second reviewer. |
Just a quick follow-up to #3891, addressing the outstanding comments there.