Introduce FundingTransactionReadyForSignatures event
#3889
Conversation
|
👋 Thanks for assigning @jkczyz as a reviewer! |
| /// After signing, call [`ChannelManager::funding_transaction_signed`] with the (partially) signed | ||
| /// funding transaction. | ||
| /// | ||
| /// Generated in [`ChannelManager`] message handling. |
There was a problem hiding this comment.
Could you add a "Failure Behavior and Persistence" section as is done for other events?
There was a problem hiding this comment.
Yeah and it makes sense to replay this after failure to handle, but not to persist across restarts as the new channel/splice won't be persisted before signing, anyway.
| let witnesses: Vec<_> = transaction | ||
| .input | ||
| .into_iter() | ||
| .filter_map(|input| if input.witness.is_empty() { None } else { Some(input.witness) }) | ||
| .collect(); |
There was a problem hiding this comment.
Don't have a strong opinion here, but seems we can avoid this by passing the Transaction through and only collecting witnesses when we are ready to construct TxSignatures.
There was a problem hiding this comment.
Cool, yeah will look at changing this after fixups.
dunxen
force-pushed
the
2025-06-readyforsigningevent
branch
from
165d59d to
8ca6d79
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3889 +/- ##
==========================================
- Coverage 89.65% 89.61% -0.05%
==========================================
Files 164 164
Lines 134661 134749 +88
Branches 134661 134749 +88
==========================================
+ Hits 120733 120757 +24
- Misses 11247 11317 +70
+ Partials 2681 2675 -6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
1 similar comment
The `FundingTransactionReadyForSignatures` event requests witnesses from the client for their contributed inputs to an interactively constructed transaction. The client calls `ChannelManager::funding_transaction_signed` to provide the witnesses to LDK.
dunxen
force-pushed
the
2025-06-readyforsigningevent
branch
from
890633d to
a1de384
Compare
| Some(Event::FundingTransactionReadyForSigning { | ||
| channel_id: self.context.channel_id, | ||
| counterparty_node_id: self.context.counterparty_node_id, | ||
| user_channel_id: self.context.user_id, | ||
| unsigned_transaction: signing_session.unsigned_tx().build_unsigned_tx(), | ||
| }) |
There was a problem hiding this comment.
We typically don't want to return an Event directly given we only expect to use a specific variant. Instead, could you return the transaction and have ChannelManager form the Event from it?
Cherry-picked from #3735 as it is relevant to splicing and will unblock testing after #3736 lands.
The
FundingTransactionReadyForSignaturesevent requests witnesses from the client for their contributed inputs to an interactively constructed transaction.The client calls
ChannelManager::funding_transaction_signedto provide the witnesses to LDK.