WIP: Decrypt inbound Trampoline onions #3585
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arik-so
force-pushed
the
arik/trampoline/inbound-parsing
branch
2 times, most recently
from
098ccea to
8127bc5
Compare
In a subsequent commit, we will be storing `TrampolineOnionPacket`s within `PendingHTLCRouting`, requiring that they be serialized for storage. To do so, `RequiredWrapper`'s requirements must be loosened to only require `LengthReadable` instead of `Readable`.
Forwarding Trampoline packets requires storing their shared secrets on top of the outer onion's shared secrets, as well as referencing the next hop by its node ID as opposed to by an SCID. We modify PendingHTLCRouting to adequately represent this information.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3585 +/- ##
==========================================
- Coverage 88.56% 88.41% -0.15%
==========================================
Files 149 149
Lines 115770 115925 +155
Branches 115770 115925 +155
==========================================
- Hits 102530 102499 -31
- Misses 10737 10912 +175
- Partials 2503 2514 +11 ☔ View full report in Codecov by Sentry. |
In order to move the Trampoline-specific data from the onion decryption layer to the PendingHTLCRouting enum, we need to make the NextPacketDetails more descriptive, which we do here by virtue of converting the outbound_scid field into an enum than is more expressive in its Trampoline variant.
arik-so
force-pushed
the
arik/trampoline/inbound-parsing
branch
from
8127bc5 to
63608c2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a WIP that depends on #3386 and #3579.