Skip to content

Async receive prefactor #3517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jan 24, 2025
Merged

Async receive prefactor #3517

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
708e8b5
Tests: DRY failing a blinded HTLC backwards
valentinewallace Jan 6, 2025
da8cb9a
Tests: DRY static invoice creation
valentinewallace Jan 8, 2025
0611e60
Add handle_held_htlc_available MessageContext param
valentinewallace Dec 4, 2024
135f757
Fail earlier on expired static invoice
valentinewallace Jan 6, 2025
8331791
Fail out-of-PaymentContext inbound keysends
valentinewallace Jan 6, 2025
f799e6b
Tweak RetryableSendFailure::PaymentExpired docs
valentinewallace Jan 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion fuzz/src/onion_message.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,8 @@ struct TestAsyncPaymentsMessageHandler {}

impl AsyncPaymentsMessageHandler for TestAsyncPaymentsMessageHandler {
fn handle_held_htlc_available(
&self, _message: HeldHtlcAvailable, responder: Option<Responder>,
&self, _message: HeldHtlcAvailable, _context: AsyncPaymentsContext,
responder: Option<Responder>,
) -> Option<(ReleaseHeldHtlc, ResponseInstruction)> {
let responder = match responder {
Some(resp) => resp,
Expand Down
4 changes: 2 additions & 2 deletions lightning/src/events/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -561,8 +561,8 @@ pub enum PaymentFailureReason {
#[cfg_attr(feature = "std", doc = "")]
#[cfg_attr(feature = "std", doc = "[`Retry::Timeout`]: crate::ln::channelmanager::Retry::Timeout")]
RetriesExhausted,
/// The payment expired while retrying, based on the provided
/// [`PaymentParameters::expiry_time`].
/// Either the BOLT 12 invoice was expired by the time we received it or the payment expired while
/// retrying based on the provided [`PaymentParameters::expiry_time`].
///
/// Also used for [`InvoiceRequestExpired`] when downgrading to version prior to 0.0.124.
///
Expand Down
Loading
Loading